Bug 370245

Summary:	Be able to rename tags which have been setted in pictures
Product:	[Applications] digikam	Reporter:	Dav <davm6101>
Component:	Tags-Engine	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	ajg02, bg+kdex, davm6101, iwannaberich, metzpinguin, tokes
Priority:	NOR
Version:	5.2.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/digikam/f748bdaa1015277e2c082c94b36dcaba48a38f76	Version Fixed In:	6.0.0
Sentry Crash Report:

Description Dav 2016-10-07 12:09:32 UTC

Rename tags in file could help us to earn many time:
For example fixing a typo error in a person tag, or reorder the locations tags defined in a picture to another picture.

Reproducible: Always

Steps to Reproduce:
1.Seek people into pictures
2.Set a name for each identified face with sometimes adding a typo in the person's name

Actual Results:  
To fix the typo error, you need to:
- create the appropriate person tag
- browse all pictures where this person is identified, and replace the identification tag by the appropriate one.
 

Expected Results:  
- from the tags directory tree, be able to rename the tag. After renaming, all pictures with the tag which contains the typo error contains now the new tag content.

Comment 1 Maik Qualmann 2016-10-07 19:05:12 UTC

This already implemented. Open Tag Manager -> right click on the tag -> Edit Tag Title (or F2 key).

Maik

Comment 2 Dav 2016-10-10 06:52:01 UTC

Yes, we are unable to rename tags but it does not also apply the update into the picture:
- set a people tag in a picture called "Jon Doe".
- exitool picture.CR2 display "Jon Doe"
- rename from Digikam "Jon Doe" into "John Doe"
- exiftool picture.CR2 still display "Jon Doe"

Comment 3 Maik Qualmann 2016-10-10 18:16:24 UTC

In this case, filter for "John Doe" in the left sidebar (tags filter). Select all and select "write Metadata to Image" from menu. There are only 3 mouse clicks or use the Maintenance tool.

Maik

Comment 4 Andrew Goodbody 2016-10-10 21:19:10 UTC

Yes that is possible, but why is that necessary? It should be done automatically. Not doing it automatically just makes the database and the image metadata be out of sync which is surely not a desirable state to be in.

Comment 5 Dav 2016-10-11 09:32:18 UTC

Hello,
Thanks you for your feedback. I didn't know this possibility.
So this feature request is not required anymore.

But I agree with Andrew: if we don't know the appropriate process, we can think this feature does not exists.
It could be easier to save tag in picture automatically, (after a confirm), or provide a configuration option which allow to enable this feature.

Anyway, thanks for your feedback.

Regards

Comment 6 Tokes 2016-10-17 19:29:29 UTC

Hi Folks, I was just about to file a feature request for "modify/rename a tag should update all tagged photos meta data, when I found this one. 

It would be great to see Digikam automatically update all effected photos metadata.

Comment 7 Tokes 2016-10-17 19:33:13 UTC

Same goes for moving a tag into a tag folder, e.g. from root/Helsinki -> places/FI/Helsinki. This modification should be updated in the metadata as well, to be able to import the photo with correct tags into another program.

Comment 8 Maik Qualmann 2017-02-19 09:10:50 UTC

*** Bug 376640 has been marked as a duplicate of this bug. ***

Comment 9 Maik Qualmann 2018-03-07 21:26:23 UTC

*** Bug 391544 has been marked as a duplicate of this bug. ***

Comment 10 Maik Qualmann 2018-03-20 20:36:51 UTC

*** Bug 392109 has been marked as a duplicate of this bug. ***

Comment 11 MarcP 2018-03-20 20:53:12 UTC

As I accidentally submitted a duplicated bug that was closed, I repeat the comment that I left in the other one (bug #392109):

The reasoning behind not saving these specific changes to the metadata is because of the possible large amount of elements that could be affected.

But the same applies to removing or adding a new tag, which are indeed saved immediately to metadata. It should be user's choice if it's worth saving those changes to the pictures (as it is asked during the first run), regardless of the time that it might take. If the option to write metadata to files is checked, it should be written. If it's not, only digikam's metadata should be changed.

The current state is inconsistent, and because of that I just realized that many changes have not actually been applied to my library.

A fair compromise would be showing a confirmation dialog before the change: "This change will affect ### pictures in your library, are you sure you want to continue?". (this is actually what happens in picasa if you try to write over more than 50 or 100 pictures at a time, if I recall correctly).

Thank you for your time.

Comment 12 Maik Qualmann 2018-03-27 21:04:53 UTC

Git commit f748bdaa1015277e2c082c94b36dcaba48a38f76 by Maik Qualmann.
Committed on 27/03/2018 at 21:03.
Pushed by mqualmann into branch 'master'.

write metadata to images after move, rename or delete tags,
we ask the user if > 100 images are affected
Related: bug 386224
FIXED-IN: 6.0.0

M  +3    -1    NEWS
M  +69   -2    core/libs/album/albummanager.cpp
M  +5    -1    core/libs/album/albummanager.h
M  +2    -2    core/tests/albummodel/albummodeltest.cpp

https://commits.kde.org/digikam/f748bdaa1015277e2c082c94b36dcaba48a38f76