Bug 370193

Summary:	Save file didn't save work
Product:	[Applications] krita	Reporter:	Brendan <bunf2014>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	annavictory72, halla
Priority:	NOR
Version:	3.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	http://commits.kde.org/krita/46283124c08c4af705b483a1f39c733fa54e1bfe	Version Fixed In:
Sentry Crash Report:

Description Brendan 2016-10-06 12:29:26 UTC

I opened up my file from yesterday to find that roughly an hour or so of work I did yesterday wasn't saved. I thought I had saved it, so I checked the file's timestamp. It was timestamped when I finished work (just after midnight), so I don't know what happened there.  I was working on a saved "incremental version".
Just renamed and opened the "~" file and my work is in there. 


Reproducible: Always

Steps to Reproduce:
1. I can't reproduce it. This is really just here in case someone else also has the problem. 
2.
3.

Comment 1 Halla Rempt 2016-10-06 14:00:22 UTC

Hi Brendan,

Thanks for taking the trouble to make a report. It's just that without a way to reproduce it, we really cannot do much with it...

Comment 2 Halla Rempt 2016-10-31 13:07:02 UTC


*** This bug has been marked as a duplicate of bug 370566 ***

Comment 3 Halla Rempt 2016-11-07 14:37:32 UTC

Git commit 95a84a951bb3a5a9b47e6a9193de8b02f3a05331 by Boudewijn Rempt.
Committed on 07/11/2016 at 14:32.
Pushed by rempt into branch 'krita/3.1'.

This restores the delayed saving dialog, which is now even weirder,
with a cancel running operating button which mostly doesn't work,
a do not save button, and a don't care, save a broken copy button.

See also

https://phabricator.kde.org/D3258
https://phabricator.kde.org/T4220
https://bugs.kde.org/show_bug.cgi?id=370566
https://bugs.kde.org/show_bug.cgi?id=369368
https://bugs.kde.org/show_bug.cgi?id=370193

M  +13   -0    libs/image/kis_annotation.h
M  +98   -39   libs/image/kis_image.cc
M  +13   -1    libs/image/kis_image.h
M  +38   -0    libs/image/kis_layer_composition.cpp
M  +2    -0    libs/image/kis_layer_composition.h
M  +10   -0    libs/image/kis_layer_utils.cpp
M  +6    -0    libs/image/kis_layer_utils.h
M  +0    -1    libs/image/kis_name_server.h
M  +0    -1    libs/image/kis_node_facade.cpp
M  +3    -1    libs/image/kis_node_facade.h
M  +0    -1    libs/image/kis_node_graph_listener.cpp
M  +4    -1    libs/image/kis_node_graph_listener.h
M  +8    -0    libs/image/recorder/kis_node_query_path.cc
M  +1    -0    libs/image/recorder/kis_node_query_path.h
M  +113  -2    libs/image/tests/kis_image_test.cpp
M  +1    -0    libs/image/tests/kis_image_test.h
M  +65   -20   libs/ui/KisDocument.cpp
M  +13   -0    libs/ui/KisDocument.h
M  +4    -1    libs/ui/dialogs/kis_delayed_save_dialog.cpp
M  +26   -8    libs/ui/dialogs/kis_delayed_save_dialog.ui
M  +3    -1    libs/ui/flake/kis_shape_layer.cc
M  +3    -1    libs/ui/kra/kis_kra_save_visitor.cpp
M  +2    -4    plugins/impex/bmp/kis_bmp_export.cpp
M  +3    -0    plugins/impex/brush/KisAnimatedBrushAnnotation.h
M  +16   -19   plugins/impex/brush/kis_brush_export.cpp
M  +1    -1    plugins/impex/csv/kis_csv_export.cpp
M  +1    -6    plugins/impex/exr/exr_export.cc
M  +7    -9    plugins/impex/heightmap/kis_heightmap_export.cpp
M  +1    -3    plugins/impex/jpeg/kis_jpeg_export.cc
M  +1    -1    plugins/impex/ora/ora_export.cc
M  +1    -5    plugins/impex/png/kis_png_export.cc
M  +1    -3    plugins/impex/ppm/kis_ppm_export.cpp
M  +2    -2    plugins/impex/psd/psd_export.cc
M  +1    -1    plugins/impex/psd/psd_resource_block.cpp
M  +14   -2    plugins/impex/psd/psd_resource_block.h
M  +1    -1    plugins/impex/psd/psd_saver.cpp
M  +1    -1    plugins/impex/qml/qml_export.cc
M  +3    -3    plugins/impex/spriter/kis_spriter_export.cpp
M  +2    -5    plugins/impex/tga/kis_tga_export.cpp
M  +5    -8    plugins/impex/tiff/kis_tiff_export.cc

http://commits.kde.org/krita/95a84a951bb3a5a9b47e6a9193de8b02f3a05331

Comment 4 Halla Rempt 2016-11-16 10:34:55 UTC

Git commit c7eb0977e020b849810eb275619f8aa87eb616bc by Boudewijn Rempt.
Committed on 16/11/2016 at 10:30.
Pushed by rempt into branch 'rempt/impex-refactoring'.

Port the save-saving patch from 3.1

This restores the delayed saving dialog, which is now even weirder,
with a cancel running operating button which mostly doesn't work,
a do not save button, and a don't care, save a broken copy button.

See also

https://phabricator.kde.org/D3258
https://phabricator.kde.org/T4220
https://bugs.kde.org/show_bug.cgi?id=370566
https://bugs.kde.org/show_bug.cgi?id=369368
https://bugs.kde.org/show_bug.cgi?id=370193

M  +52   -12   libs/ui/KisDocument.cpp
M  +14   -0    libs/ui/KisDocument.h
M  +4    -1    libs/ui/dialogs/kis_delayed_save_dialog.cpp
M  +26   -8    libs/ui/dialogs/kis_delayed_save_dialog.ui
M  +2    -2    plugins/impex/bmp/kis_bmp_export.cpp
M  +9    -12   plugins/impex/brush/kis_brush_export.cpp
M  +2    -2    plugins/impex/csv/csv_saver.cpp
M  +1    -6    plugins/impex/exr/exr_export.cc
M  +2    -4    plugins/impex/heightmap/kis_heightmap_export.cpp
M  +1    -3    plugins/impex/jpeg/kis_jpeg_export.cc
M  +2    -2    plugins/impex/kra/kra_converter.cpp
M  +1    -2    plugins/impex/kra/kra_export.cpp
M  +1    -1    plugins/impex/ora/ora_export.cc
M  +1    -1    plugins/impex/png/kis_png_export.cc
M  +1    -4    plugins/impex/ppm/kis_ppm_export.cpp
M  +1    -1    plugins/impex/psd/psd_saver.cpp
M  +1    -1    plugins/impex/qml/qml_export.cc
M  +3    -3    plugins/impex/spriter/kis_spriter_export.cpp
M  +2    -2    plugins/impex/tga/kis_tga_export.cpp
M  +5    -8    plugins/impex/tiff/kis_tiff_export.cc

http://commits.kde.org/krita/c7eb0977e020b849810eb275619f8aa87eb616bc

Comment 5 Scott Petrovic 2016-11-19 15:25:06 UTC

Git commit 46283124c08c4af705b483a1f39c733fa54e1bfe by Scott Petrovic, on behalf of Boudewijn Rempt.
Committed on 19/11/2016 at 15:23.
Pushed by scottpetrovic into branch 'petrovic/impex-brush-editor-ui'.

Port the save-saving patch from 3.1

This restores the delayed saving dialog, which is now even weirder,
with a cancel running operating button which mostly doesn't work,
a do not save button, and a don't care, save a broken copy button.

See also

https://phabricator.kde.org/D3258
https://phabricator.kde.org/T4220
https://bugs.kde.org/show_bug.cgi?id=370566
https://bugs.kde.org/show_bug.cgi?id=369368
https://bugs.kde.org/show_bug.cgi?id=370193

M  +52   -12   libs/ui/KisDocument.cpp
M  +14   -0    libs/ui/KisDocument.h
M  +4    -1    libs/ui/dialogs/kis_delayed_save_dialog.cpp
M  +26   -8    libs/ui/dialogs/kis_delayed_save_dialog.ui
M  +2    -2    plugins/impex/bmp/kis_bmp_export.cpp
M  +9    -12   plugins/impex/brush/kis_brush_export.cpp
M  +2    -2    plugins/impex/csv/csv_saver.cpp
M  +1    -6    plugins/impex/exr/exr_export.cc
M  +2    -4    plugins/impex/heightmap/kis_heightmap_export.cpp
M  +1    -3    plugins/impex/jpeg/kis_jpeg_export.cc
M  +2    -2    plugins/impex/kra/kra_converter.cpp
M  +1    -2    plugins/impex/kra/kra_export.cpp
M  +1    -1    plugins/impex/ora/ora_export.cc
M  +1    -1    plugins/impex/png/kis_png_export.cc
M  +1    -4    plugins/impex/ppm/kis_ppm_export.cpp
M  +1    -1    plugins/impex/psd/psd_saver.cpp
M  +1    -1    plugins/impex/qml/qml_export.cc
M  +3    -3    plugins/impex/spriter/kis_spriter_export.cpp
M  +2    -2    plugins/impex/tga/kis_tga_export.cpp
M  +5    -8    plugins/impex/tiff/kis_tiff_export.cc

http://commits.kde.org/krita/46283124c08c4af705b483a1f39c733fa54e1bfe