Bug 369857

Summary: Images from the wallpapers list can't be removed
Product: [Unmaintained] kscreenlocker Reporter: soee <kontakt>
Component: kcmAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal CC: bshah, kde, mgraesslin, nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description soee 2016-10-04 11:10:01 UTC 
It looks like Screen Locking kcm for selecting wallaper uses the same component that we see in desktop settings. The problem with it when using inside kcm is that we can't remove and image from the wallpapers list.

When having opened desktop settings, wallpaper can be removed if we mark it to remove and close the window. Inside Screen Locking kcm if we do the same and close the window the wallpaper is never removed.

Reproducible: Always

Steps to Reproduce:
1. Open Screen Locking kcm
2. Go to Wallpaper tab and mark any image to be removed from the list
3. Close the window
4. Open Screen Locking kcm again

Actual Results:  
Image marked to remove is still here.

Expected Results:  
Image marked to be remove should be removed.

From the UX, UI point of view this is pretty strange how this wallpapers removal works atm. I think if we mark any image to remove than "Apply" button should switch to active and we should be able to apply changes by clicking on it and not waiting to close the window to have those images removed.
Comment 1 Kai Uwe Broulik 2016-10-04 11:47:59 UTC 
Images marked for deletion are only removed when you apply the dialog. While this isn't very ideal and obvious, it's the same for the desktop and lock screen settings. Only if you Apply it will remove the image from the list, just closing the dialog won't, in both cases.
Comment 2 soee 2016-10-04 11:57:03 UTC 
(In reply to Kai Uwe Broulik from comment #1)
> Images marked for deletion are only removed when you apply the dialog. While
> this isn't very ideal and obvious, it's the same for the desktop and lock
> screen settings. Only if you Apply it will remove the image from the list,
> just closing the dialog won't, in both cases.

By "apply" you mean pressing the Apply button or OK? If we mark image for deletion that Apply button is never active either in desktop settings or kcm. Pressing OK button indeed removes image when we are in desktop settings but does not work inside kcm.
Comment 3 Nate Graham 2018-04-29 20:34:48 UTC 
(In reply to soee from comment #0)
> I think if we mark any image to remove than "Apply"
> button should switch to active and we should be able to apply changes by
> clicking on it and not waiting to close the window to have those images
> removed.

This is exactly how it works, in fact.

(In reply to soee from comment #2)
> Pressing OK button indeed removes image when we are in desktop settings
> but does not work inside kcm.

Works for me.