Summary: | Minimum size of the separator is too big | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | loopset <miguellozanogonzalez> |
Component: | Panel | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | demm, kde |
Priority: | NOR | ||
Version: | 5.8.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
URL: | http://paste.opensuse.org/97aa0d60 | ||
Latest Commit: | http://commits.kde.org/plasma-workspace/d3fc0c18787100d1795a9115588acf91b0cd3bb3 | Version Fixed In: | |
Attachments: |
Separator too big
Like this 'should' be the separator |
Description
loopset
2016-10-03 19:47:28 UTC
Created attachment 101398 [details]
Separator too big
Created attachment 101399 [details]
Like this 'should' be the separator
Reverting is not an option. It fixes a *considerably* more major bug. However, It's not meant to cause any bad behavioural changes, so I'm happy to look into fixing whatever is wrong. Can you change it to: Layout.minimumWidth: 1 Layout.minimumHeight: 1 Layout.preferredWidth: horizontal ? plasmoid.configuration.length : 0 Layout.preferredHeight: horizontal ? 0 : plasmoid.configuration.length and tell me if that's the right end result? Yes, editing that file with what you said solves the 'issue'. In fact, that's not an issue, only a change that makes the separators look bad (on my opinion, because they can take up much space). Again, thanks! Git commit d3fc0c18787100d1795a9115588acf91b0cd3bb3 by David Edmundson. Committed on 05/10/2016 at 14:53. Pushed by davidedmundson into branch 'Plasma/5.8'. Set explicit minimum size on panelSpacer so that AppletContainer doesn't set one Summary: Commit 8e1339887a01e078b04fb18ff575c16998447665 in Plasma 5.8 removed a minimum size on the panel spacer, which is what we want, however if no minimum size is set on an applet in a panel the panel's AppletContainer sets the minmimum width to be the same as the height. This was preventing people having tiny panel spacers. Test Plan: Reporter tested the patch Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D2938 M +2 -0 applets/panelspacer/contents/ui/main.qml http://commits.kde.org/plasma-workspace/d3fc0c18787100d1795a9115588acf91b0cd3bb3 |