Bug 369823

Summary:	Minimum size of the separator is too big
Product:	[Plasma] plasmashell	Reporter:	loopset <miguellozanogonzalez>
Component:	Panel	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	demm, kde
Priority:	NOR
Version First Reported In:	5.8.0
Target Milestone:	1.0
Platform:	Other
OS:	Linux
URL:	http://paste.opensuse.org/97aa0d60
Latest Commit:	http://commits.kde.org/plasma-workspace/d3fc0c18787100d1795a9115588acf91b0cd3bb3	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Separator too big Like this 'should' be the separator

Description loopset 2016-10-03 19:47:28 UTC

Since this commit: https://github.com/KDE/plasma-workspace/commit/8e1339887a01e078b04fb18ff575c16998447665  the minimum size of the panel's separator is too big, like the screenshot provided. (without flexible mode). Before that commit, it can be resized to a little space. You may have your reasons for change that, but as you can see on the screenshot, now it looks 'ugly'. I ask this if you can revert this or make a workaround. (editing the .qml file undoing the change solves the issue). Thanks!

Reproducible: Always

Steps to Reproduce:
1.Panel settings
2.Add a separator
3.Try to resize

Actual Results:  
The separator is too big

Expected Results:  
It would be OK if the behavior of the separator were like before that commit. 

Since this doesn't depend of any SO, only the plasma version, i won't anything here.

Comment 1 loopset 2016-10-03 19:58:21 UTC

Created attachment 101398 [details]
Separator too big

Comment 2 loopset 2016-10-03 19:59:15 UTC

Created attachment 101399 [details]
Like this 'should' be the separator

Comment 3 David Edmundson 2016-10-04 08:36:39 UTC

Reverting is not an option.  It fixes a *considerably* more major bug.

However, It's not meant to cause any bad behavioural changes, so I'm happy to look into fixing whatever is wrong.

Can you change it to:
   Layout.minimumWidth: 1
    Layout.minimumHeight: 1
    Layout.preferredWidth: horizontal ? plasmoid.configuration.length : 0
    Layout.preferredHeight: horizontal ? 0 : plasmoid.configuration.length

and tell me if that's the right end result?

Comment 4 loopset 2016-10-04 13:25:55 UTC

Yes, editing that file with what you said solves the 'issue'. In fact, that's not an issue, only a change that makes the separators look bad (on my opinion, because they can take up much space). Again, thanks!

Comment 5 David Edmundson 2016-10-05 14:53:47 UTC

Git commit d3fc0c18787100d1795a9115588acf91b0cd3bb3 by David Edmundson.
Committed on 05/10/2016 at 14:53.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Set explicit minimum size on panelSpacer so that AppletContainer doesn't set one

Summary:
Commit 8e1339887a01e078b04fb18ff575c16998447665 in Plasma 5.8 removed a
minimum size on the panel spacer, which is what we want, however if no
minimum size is set on an applet in a panel the panel's AppletContainer
sets the minmimum width to be the same as the height.

This was preventing people having tiny panel spacers.

Test Plan: Reporter tested the patch

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2938

M  +2    -0    applets/panelspacer/contents/ui/main.qml

http://commits.kde.org/plasma-workspace/d3fc0c18787100d1795a9115588acf91b0cd3bb3