Bug 369657

Summary:	XMP subject matter code can be added twice
Product:	[Applications] digikam	Reporter:	Christopher Yeleighton <giecrilj>
Component:	Plugin-Generic-MetadataEdit	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	5.3.0
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/digikam/commit/d6a94becc2f97a5514d6f7c02583c4f0fb18eb57	Version Fixed/Implemented In:	6.2.0
Sentry Crash Report:

Description Christopher Yeleighton 2016-10-03 00:32:12 UTC

The same XMP subject matter code can be added twice to the same image; if this happens, the subject list contains a spurious entry ::::.

Reproducible: Always

Steps to Reproduce:
1. Add XMP standard subject matter code 01000000 to an image.
2. Add the same subject matter code once more.


Actual Results:  
2. The subject matter list contains:
XMP:01000000:arts, culture and entertainment::
::::

Expected Results:  
2. It should not be possible; standard codes already attached to the image should be disabled.

Comment 1 caulier.gilles 2016-11-28 08:47:25 UTC

Can you reproduce the problem using digiKam Linux AppImage bundle ? The last bundle is available at this url:

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier

Comment 2 Maik Qualmann 2019-06-04 06:07:33 UTC

Git commit d6a94becc2f97a5514d6f7c02583c4f0fb18eb57 by Maik Qualmann.
Committed on 04/06/2019 at 06:06.
Pushed by mqualmann into branch 'master'.

fix handling with subject matter code
FIXED-IN: 6.2.0

M  +2    -1    NEWS
M  +3    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcsubjects.cpp
M  +3    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpsubjects.cpp
M  +3    -1    core/libs/template/subjectedit.cpp
M  +9    -2    core/libs/widgets/metadata/subjectwidget.cpp
M  +2    -0    core/libs/widgets/metadata/subjectwidget.h

https://invent.kde.org/kde/digikam/commit/d6a94becc2f97a5514d6f7c02583c4f0fb18eb57