Bug 369529

Summary:	Dark Theme is not applied everywhere
Product:	[Applications] kmymoney	Reporter:	radzaquiel
Component:	general	Assignee:	KMyMoney Devel Mailing List <kmymoney-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mahueb55
Priority:	NOR
Version:	4.8.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/kmymoney/cf2a75bb3333d91e4a3bb6aa13ff41ad412d7a93	Version Fixed In:	5.0.0
Sentry Crash Report:

Description radzaquiel 2016-09-29 12:18:17 UTC

I'm using Plasma 5 with Breeze Dark theme.
In KMyMoney, there are some areas who are not fully adapted to theme changing.

Reproducible: Always

Steps to Reproduce:
1. Open KMyMoney
2. Go to "Opérations récurrentes" 
3. Edit/Create one

Actual Results:  
"Name", "Account" & "Amount" fields are white background with light grey font

Expected Results:  
"Name", "Account" & "Amount" fields should be dark background with light grey font

Sorry if some word are in French as I use this software in French.

That bug also occurs in Category & Account editing.

Comment 1 mahueb55 2017-01-14 12:58:43 UTC

Issue seems to affect all input fields that are set to "input required"; the initial default for the background color is set to rgb 255,255,221 in /kmymoney/kmymoney.kcfg (independently from the theme) - this is indeed hardly readable with dark themes that tend to use a light font color (only background color is set explicitly; font color is determined by chosen theme though).

The setting can however be overridden manually by the user via Settings -> Configure kMyMoney -> Colors -> Background -> Special Background Colors -> Required Field.

Comment 2 wojnilowicz 2017-09-21 16:30:25 UTC

Git commit cf2a75bb3333d91e4a3bb6aa13ff41ad412d7a93 by Łukasz Wojniłowicz.
Committed on 21/09/2017 at 15:55.
Pushed by wojnilowicz into branch 'master'.

Improve compatibility with dark color schemes

Changes:
1) css files compatible with themes are generated in ~/.config/kmymoney/
each time at startup,
2) redundant colors were removed from options and are always fetched
from color scheme,
3) fixed colors and letter cases in css files for css adaptability,
4) KMyMoneyGlobalSettings::schemeColor is for all color requests,
5) Use AppDataLocation instead of deprecated DataLocation.
FIXED-IN:5.0
Signed-off-by: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>

M  +1    -1    kmymoney/dialogs/settings/CMakeLists.txt
M  +15   -1    kmymoney/dialogs/settings/ksettingscolors.cpp
M  +10   -11   kmymoney/dialogs/settings/ksettingscolors.h
A  +204  -0    kmymoney/dialogs/settings/ksettingscolors.ui
D  +0    -386  kmymoney/dialogs/settings/ksettingscolorsdecl.ui
M  +1    -1    kmymoney/dialogs/transactioneditor.cpp
M  +12   -13   kmymoney/html/kmymoney.css
M  +7    -9    kmymoney/html/welcome.css
M  +35   -13   kmymoney/kmymoney.cpp
M  +30   -44   kmymoney/kmymoney.kcfg
M  +52   -15   kmymoney/kmymoneyglobalsettings.cpp
M  +20   -2    kmymoney/kmymoneyglobalsettings.h
M  +2    -2    kmymoney/kmymoneyutils.cpp
M  +2    -2    kmymoney/models/accountsmodel.cpp
M  +1    -1    kmymoney/models/ledgermodel.cpp
M  +31   -8    kmymoney/reports/listtable.cpp
M  +5    -12   kmymoney/reports/pivottable.cpp
M  +7    -2    kmymoney/reports/reporttable.cpp
M  +12   -12   kmymoney/views/kforecastview.cpp
M  +1    -1    kmymoney/views/kgloballedgerview.cpp
M  +2    -2    kmymoney/views/khomeview.cpp
M  +1    -1    kmymoney/widgets/kguiutils.cpp
M  +7    -6    kmymoney/widgets/register.cpp
M  +4    -4    kmymoney/widgets/stdtransactiondownloaded.cpp
M  +2    -2    kmymoney/widgets/stdtransactionmatched.cpp
M  +4    -4    kmymoney/widgets/transaction.cpp

https://commits.kde.org/kmymoney/cf2a75bb3333d91e4a3bb6aa13ff41ad412d7a93