Bug 369517

Summary: digiKam from 5.7.0 tarball installs libvkontakte translations even if libvkontakte is disabled
Product: [Applications] digikam Reporter: Luca Beltrame <lbeltrame>
Component: Bundle-TarballAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: arojas, caulier.gilles, rdieter
Priority: NOR    
Version: 5.2.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://commits.kde.org/digikam-software-compilation/a4915c9d4f1b91db506aeb68f890b54e36ec3d1e Version Fixed In: 5.8.0
Sentry Crash Report:

Description Luca Beltrame 2016-09-29 08:37:28 UTC 
As the summary says, this showed up during package review at openSUSE:

[  563s] -- Compilation configuration for: digikam-software-collection
[....]
[  563s] -- Local shared libkvkontakte will be compiled.... NO

But afterwards, during build stage:

[  852s] [  8%] Generating libkvkontakte.gmo
[  852s] cd /home/abuild/rpmbuild/BUILD/digikam-5.2.0/po/bs && /usr/bin/msgfmt -o /home/abuild/rpmbuild/BUILD/digikam-5.2.0/build/po/bs/libkvkontakte.gmo /home/abuild/rpmbuild/BUILD/digikam-5.2.0/po/bs/libkvkontakte.po

And later on:

[ 7826s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/digikam-5.2.0-157.1.x86_64/usr/share/locale/es/LC_MESSAGES/libkvkontakte.mo

(example for one file).

Translations from disabled components should not be installed, IMO. Unless of course, they're still used somewhere else.

Reproducible: Always
Comment 1 Antonio Rojas 2016-09-30 12:46:56 UTC 
This is the only way to get libkvkontakte translations currently, since there is no tarball available, so one has to compile it from git which doesn't contain translations.
Comment 2 Luca Beltrame 2016-09-30 12:58:38 UTC 
The problem is not the presence of the translations, but the fact that they're installed even if the bulding of the library is disabled. It shouldn't install / generate them if disabled (they are not going to be used).
Comment 3 Antonio Rojas 2016-09-30 13:00:33 UTC 
(In reply to Luca Beltrame from comment #2)
> The problem is not the presence of the translations, but the fact that
> they're installed even if the bulding of the library is disabled. It
> shouldn't install / generate them if disabled (they are not going to be
> used).

Sure, I was speaking of the case where you build it against an already installed libkvkontakte (such as for distro packaging)
Comment 4 caulier.gilles 2016-10-02 19:50:27 UTC 
Git commit e07683db9d5aeab135970f475929afd508764bfb by Gilles Caulier.
Committed on 02/10/2016 at 19:48.
Pushed by cgilles into branch 'master'.

add new options in Ruby script to handle CMake configuration with i18n extraction.
If digiKam, or Kipiplugins, or libkvkontake is enabled or disabled, relevant .po
files are extracted from subversion server.
FIXED-IN: 5.3.0

M  +13   -1    CMakeLists.txt
M  +2    -2    bootstrap.linux
M  +3    -5    project/release/fetch_l10n_doc.rb
M  +91   -38   project/release/fetch_l10n_po.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/e07683db9d5aeab135970f475929afd508764bfb
Comment 5 Antonio Rojas 2017-09-06 09:24:37 UTC 
digikam 5.7.0 still installs libkvkontakte translations unconditionally. Since there is a libkvkontakte tarball now which includes translations, this is now creating actual conflicts instead of just some unnecessary files. Please remove the libkvkontakte translations from the tarballs since they are shipped in the libkvkontakte tarball already.
Comment 6 caulier.gilles 2017-09-06 16:29:27 UTC 
Git commit a4915c9d4f1b91db506aeb68f890b54e36ec3d1e by Gilles Caulier.
Committed on 06/09/2017 at 16:28.
Pushed by cgilles into branch 'master'.

do not checkout libvkontakte i18n when tarball processing.
FIXED-IN: 5.8.0

M  +0    -4    CMakeLists.txt
M  +1    -24   project/release/fetch_l10n_po.rb

https://commits.kde.org/digikam-software-compilation/a4915c9d4f1b91db506aeb68f890b54e36ec3d1e