Bug 369479

Summary:	git master: moving keyframes of a resized (shortened) transition does not update the animated transition parameters correctly
Product:	[Applications] kdenlive	Reporter:	Wegwerf <wegwerf-1-2-3>
Component:	Video Effects & Transitions	Assignee:	Vincent PINON <vpinon>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	16.08.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Wegwerf 2016-09-28 13:51:29 UTC

This is a difficult bug, but one that really is annoying. Assume a transition of length 6:00 with four keyframes at 0:00, 0:12, 5:12, and 5:24. Alpha is 0%, 100%, 100%, then 0% -- a classic fade.

You can trigger this bug only when after you've edited the keyframes of a transition for the first time, doing other work, then selecting the transition again. Now, you have some keyframes somewhere in the middle of the transition. Next, *shorten* the transition several frames. Then move the keyframes forward, towards the end of the transition.

Notice that while the alpha parameter is correctly animated, the project monitor still shows the old situation before you moved the keyframes. It seems that Kdenlive does not correctly update the animated parameters of the MLT transition object, only its animated dialog parameters get updated.

If you now resize the transition to be longer, then the sync seems to be occur. However, resizing a transition to make it shorter seems to put the UI dialog out of sync with the MLT parameters.

Reproducible: Always

Comment 1 Jean-Baptiste Mardelle 2016-09-28 20:41:40 UTC

Git commit dcf45a03726a674425f65b98015a4712fa109f9f by Jean-Baptiste Mardelle.
Committed on 28/09/2016 at 20:41.
Pushed by mardelle into branch 'master'.

Ensure we always have a keyframe at the end of a transition when resizing it to avoid artifacts

M  +1    -1    src/effectstack/widgets/animationwidget.cpp
M  +23   -11   src/timeline/transition.cpp

http://commits.kde.org/kdenlive/dcf45a03726a674425f65b98015a4712fa109f9f

Comment 2 Wegwerf 2016-09-29 05:43:27 UTC

Thank you very much! Will check this soon... :)

Comment 3 Wegwerf 2016-09-30 19:13:35 UTC

This is fixed, many thanks! This bug was really driving me nuts several times when I was in the process of finishing daytime projects, trimming transitions into final length, just to see the timeline not correctly picking up the adjusted keyframes.