| Summary: | User photo/avatar doesn't support antialias | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Guo Yunhe <i> |
| Component: | Application Launcher (Kickoff) widget | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, notmart, notuxius, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.5.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/9da4da7ea7f71dcf6da2b6b263f7a636029c4a25 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot of user photo/avatar in application launcher
My user avatar photo Screenshot compare user profile dialog and a dialog I created Screenshot compare application launcher and a dialog I created avatar in kicker, plasma 5.12.4 avatar in user manager, plasma 5.12.4 |
||
|
Description
Guo Yunhe
2016-09-25 13:09:51 UTC
Created attachment 101282 [details]
Screenshot of user photo/avatar in application launcher
the item is just an Image, which has smooth: true. is the avatar icon stored pre-scaled? (In reply to Marco Martin from comment #2) > the item is just an Image, which has smooth: true. > is the avatar icon stored pre-scaled? Not pre-scaled, it is a large JPEG picture 600x600px. Created attachment 101302 [details]
My user avatar photo
Created attachment 101303 [details]
Screenshot compare user profile dialog and a dialog I created
The left avatar is in the KDE user management. The right avatar is in a dialog I created in Qt Designer. They use the same picture and same size.
I can see that the left one is not as smooth as the right one. When you scale the screenshot 2 times bigger, the difference is more visiable.
Created attachment 101304 [details]
Screenshot compare application launcher and a dialog I created
Can confirm this bug in: Distribution: KDE neon Developer Edition Unstable Branches KDE Plasma Version: 5.10.90 KDE Frameworks Version: 5.37.0 Qt Version: 5.9.1 Kernel Version: 4.10.0-32-generic Noticed that antialiasing isn't used for newly chosen image after pressing 'Apply' button in 'User Manager' settings window - before pressing Apply - antialiasing is used for new image - maybe resizing of image after applying? Antialiasing isn't used in 'User Manager' settings window itself - but antialiasing is used for Login Screen, Lock Screen and Leave dialog windows image. Created attachment 111824 [details]
avatar in kicker, plasma 5.12.4
I use plasma 5.12.4 on Arch Linux.
My avatar looks fuzzy in kicker and user manager (see screenshots).
It looks good in SDDM, logout screen and lock screen.
Created attachment 111825 [details]
avatar in user manager, plasma 5.12.4
Git commit 9da4da7ea7f71dcf6da2b6b263f7a636029c4a25 by David Edmundson, on behalf of Kirill Tatunov.
Committed on 02/05/2018 at 14:43.
Pushed by davidedmundson into branch 'Plasma/5.12'.
Fix avatar picture aliasing and stretching in kickoff
Summary:
QML Image element has some smoothing when scaling an image by default but it's not enough and the picture still looks a bit pixelated. This patch fixes that.
Also while I was at it, I added keeping the aspect ratio, because no one likes their avatars stretched.
Test Plan:
Before: {F5819424} {F5819425}
After: {F5819429} {F5819430}
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12469
M +5 -0 applets/kickoff/package/contents/ui/Header.qml
https://commits.kde.org/plasma-desktop/9da4da7ea7f71dcf6da2b6b263f7a636029c4a25
Thanks for the fix! |