Bug 369321

Summary: Translation of digikam + showfoto docbooks missing in digikam-5.2.0 tarball
Product: [Applications] digikam Reporter: Burkhard Lück <lueck>
Component: DocumentationAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, luigi.toscano
Priority: NOR    
Version: 5.2.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.3.0
Sentry Crash Report:

Description Burkhard Lück 2016-09-25 12:15:01 UTC
doc translation of digikam version 5.0 for locale ca, it, nl. pt, pt_BR, sv, uk are missing in the tarball
Comment 1 caulier.gilles 2016-09-25 12:31:20 UTC
There is no translation yet.

Handbook is huge and so far to be finalized. The translations take time and as we cut the large docbook files in small parts, translator needs to adjust translations workflow.

So the handbook translations will be include in tarball in the far future.

Gilles Caulier
Comment 2 Burkhard Lück 2016-09-25 12:37:25 UTC
(In reply to caulier.gilles from comment #1)
> There is no translation yet.
> 
That is wrong.

digikam has 7 translated dobooks updated for 5.0, see Description
Comment 3 caulier.gilles 2016-09-25 12:42:49 UTC
Are you sure that ALL handbooks files are present in listed languages :

https://quickgit.kde.org/?p=digikam-doc.git&a=blob&f=TODO

The script used to build tarball with translations will check if all files are present for current language to package. If one is missing, the language is not included. Note that the script do not check if file is fully translated of course. It check if file is present to SVN, in goal to have a compilable translated handbook.

Gilles Caulier
Comment 4 Burkhard Lück 2016-09-25 13:35:42 UTC
Scripty permforms a check for valid language docbook in his daily run, see e.g ftp://l10n.kde.org/160920.trunk_l10n-kf5 and reports invalid language docbooks in his log.
Thats why I am sure we have some fully translated language docbooks, e.g. checkXML5 /home/kdeframeworks/src/l10n-kf5/uk/docs/extragear-graphics/digikam/index.docbook reports no error, that means the digikam docbook is fully translated in locale uk.
Comment 5 caulier.gilles 2016-09-25 15:20:55 UTC
ok, 

I will run the digiKam release script to see if at least with UK, the complete handbook files are found properly.

Gilles Caulier
Comment 6 Burkhard Lück 2016-09-25 16:08:33 UTC
where do I find the release script digikam uses?
Comment 7 caulier.gilles 2016-09-25 16:09:09 UTC
This is the result of digiKam release script that i configured to checkout handbook translations :

-- Extract documentation translation files from git repositories. Please wait, it can take a while...
-- NOTE: (u) want mean uncomplete translations files, which will be removed from compilation.
digikam: af(u) ar(u) az(u) be(u) bg(u) bn(u) br(u) bs(u) ca(u) cs(u) csb(u) cy(u) da(u) de(u) el(u) en_GB(u) eo(u) es(u) et(u) eu(u) fa(u) fi(u) fo(u) fr(u) fy(u) ga(u) gl(u) ha(u) he(u) hi(u) hr(u) hsb(u) hu(u) id(u) is(u) it(u) ja(u) ka(u) kk(u) km(u) ko(u) ku(u) lb(u) lo(u) lt(u) lv(u) mi(u) mk(u) mn(u) ms(u) mt(u) nb(u) nds(u) ne(u) nl(u) nn(u) nso(u) oc(u) pa(u) pl(u) pt(u) pt_BR(u) ro(u) ru(u) rw(u) se(u) sk(u) sl(u) sq(u) sr(u) sr@Latn(u) ss(u) sv(u) ta(u) te(u) tg(u) th(u) tr(u) tt(u) uk(u) uz(u) uz@cyrillic(u) ven(u) vi(u) wa(u) xh(u) zh_CN(u) zh_HK(u) zh_TW(u) zu(u) 
showfoto: 
-- Documentation translation files extraction done.

As expected, none has full list of files from digiKam handbook. All are dropped from tarball.

Did you take a look in 

https://quickgit.kde.org/?p=digikam-doc.git&a=blob&f=TODO

... where you have all docbook files listed which constitute the digiKam handbook ? The original hanbook, written more than 10 year ago was cut in small parts now. The release script will check if all files are present in SVN to considerate that translated documentation is ready to by packaged for a specific language.

Gilles Caulier
Comment 8 caulier.gilles 2016-09-25 16:12:54 UTC
The release script is in digiKAm Software Compilation repository here :

https://quickgit.kde.org/?p=digikam-software-compilation.git&a=tree

The file is this one :

https://quickgit.kde.org/?p=digikam-software-compilation.git&a=blob&h=1f5854a783769f3601866437950aae33d6251e2a&f=project%2Frelease%2Ffetch_l10n_doc.rb&o=plain

It's called at configuration time by bootstrap shell script on top of repository when right options are turned on :

DIGIKAMSC_CHECKOUT_DOC=ON
DIGIKAMSC_COMPILE_DOC=ON

Gilles Caulier
Comment 9 Burkhard Lück 2016-09-25 16:20:16 UTC
(In reply to caulier.gilles from comment #7)
> 
> As expected, none has full list of files from digiKam handbook. All are
> dropped from tarball.
> 
Your script seems to be broken, at least locales it, nl. pt, pt_BR, uk have a fully translated docbook for digikam + showfoto 5.0 - verified with checkXML5
Comment 10 caulier.gilles 2016-09-25 16:26:40 UTC
But between 5.0 and 5.2, a lots of changes have been performed. As i said, the docbook have been cut in small parts and new parts have been add. The list of docbook files is :

annexes-credits.docbook
editor-cm-connection.docbook
editor-cm-definitions.docbook
editor-cm.docbook
editor-cm-intro.docbook
editor-cm-monitor.docbook
editor-cm-pcs.docbook
editor-cm-rawfile.docbook
editor-cm-rendering.docbook
editor-cm-srgb.docbook
editor-cm-wkspace.docbook
editor-color-auto.docbook
editor-color-bw.docbook
editor-color-correction.docbook
editor-color-curves.docbook
editor-color.docbook
editor-color-exposure.docbook
editor-color-levels.docbook
editor-color-mixer.docbook
editor-color-neg.docbook
editor-color-wb.docbook
editor-decorate-border.docbook
editor-decorate.docbook
editor-decorate-inserttext.docbook
editor-decorate-texture.docbook
editor-enhance-blur.docbook
editor-enhance-distortion.docbook
editor-enhance.docbook
editor-enhance-hotpixels.docbook
editor-enhance-inpaint.docbook
editor-enhance-lenscorrection.docbook
editor-enhance-localcontrast.docbook
editor-enhance-nr.docbook
editor-enhance-redeyes.docbook
editor-enhance-restoration.docbook
editor-enhance-sharpen.docbook
editor-enhance-vignetting.docbook
editor-filters-blurfx.docbook
editor-filters-charcoal.docbook
editor-filters-colorsfx.docbook
editor-filters-distortionfx.docbook
editor-filters.docbook
editor-filters-emboss.docbook
editor-filters-filmgrain.docbook
editor-filters-oilpaint.docbook
editor-filters-raindrops.docbook
editor-photoediting.docbook
editor-transform-crop.docbook
editor-transform.docbook
editor-transform-freerotation.docbook
editor-transform-liquid.docbook
editor-transform-perspective.docbook
editor-transform-resize.docbook
editor-transform-rotateflip.docbook
editor-transform-shear.docbook
editor-using.docbook
index.docbook
intro-background.docbook
intro-camerasupport.docbook
intro-contrib.docbook
intro-database.docbook
intro-firstrun.docbook
intro-imageformats.docbook
intro-info.docbook
intro-movieformats.docbook
intro-pluginsupport.docbook
menu-bqm.docbook
menu-camera.docbook
menu-editor.docbook
menu-lighttable.docbook
menu-mainwindow.docbook
tool-acquireimages.docbook
tool-advrename.docbook
tool-calendar.docbook
tool-dropbox.docbook
tool-expoblending.docbook
tool-facebook.docbook
tool-findduplicates.docbook
tool-flashexport.docbook
tool-flickrexport.docbook
tool-geolocationeditor.docbook
tool-googleexport.docbook
tool-imageshack.docbook
tool-imgur.docbook
tool-kmlexport.docbook
tool-maintenance.docbook
tool-mediawiki.docbook
tool-metadataeditor.docbook
tool-panorama.docbook
tool-piwigoexport.docbook
tool-presentation.docbook
tool-printwizard.docbook
tool-rajce.docbook
tool-remotestorage.docbook
tool-sendimages.docbook
tool-smug.docbook
tool-vkontakte.docbook
tool-yandexfotki.docbook
using-bqm.docbook
using-camera-basis.docbook
using-camera.docbook
using-camera-gps.docbook
using-camera-intro.docbook
using-camera-processing.docbook
using-dam-build.docbook
using-dam-copyright.docbook
using-dam-corruption.docbook
using-dam.docbook
using-dam-intro.docbook
using-dam-workflow.docbook
using-lighttable.docbook
using-mainwindow-albumsview.docbook
using-mainwindow-datesview.docbook
using-mainwindow.docbook
using-mainwindow-fuzzysearches.docbook
using-mainwindow-imageview.docbook
using-mainwindow-intro.docbook
using-mainwindow-labelsview.docbook
using-mainwindow-peopleview.docbook
using-mainwindow-searchesview.docbook
using-mainwindow-tagsview.docbook
using-mainwindow-timelineview.docbook
using-setup-album.docbook
using-setup-camera.docbook
using-setup-cm.docbook
using-setup-collections.docbook
using-setup-database.docbook
using-setup.docbook
using-setup-editor-iface.docbook
using-setup-editor-raw.docbook
using-setup-editor-save.docbook
using-setup-editor-version.docbook
using-setup-intro.docbook
using-setup-lighttable.docbook
using-setup-metadata.docbook
using-setup-metadata-intro.docbook
using-setup-metadata-rotation-ac.docbook
using-setup-metadata-views.docbook
using-setup-mimetype.docbook
using-setup-misc-behavior.docbook
using-setup-misc.docbook
using-setup-plugins.docbook
using-setup-quality.docbook
using-setup-slideshow.docbook
using-setup-templates.docbook
using-setup-theme.docbook
using-setup-tooltip.docbook
using-sidebar-captions.docbook
using-sidebar-colors.docbook
using-sidebar.docbook
using-sidebar-filters.docbook
using-sidebar-intro.docbook
using-sidebar-maps.docbook
using-sidebar-metadata.docbook
using-sidebar-properties.docbook
using-sidebar-tools.docbook
using-tagsmngr.docbook

... my script is not broken...

Gilles Caulier
Comment 11 Luigi Toscano 2016-09-25 16:37:52 UTC
(In reply to caulier.gilles from comment #10)
> But between 5.0 and 5.2, a lots of changes have been performed. As i said,
> the docbook have been cut in small parts and new parts have been add. The
> list of docbook files is :
> 
> annexes-credits.docbook
> editor-cm-connection.docbook
> editor-cm-definitions.docbook
> editor-cm.docbook
> editor-cm-intro.docbook
> editor-cm-monitor.docbook
> editor-cm-pcs.docbook
> editor-cm-rawfile.docbook
> editor-cm-rendering.docbook
> editor-cm-srgb.docbook
> editor-cm-wkspace.docbook
> editor-color-auto.docbook
> editor-color-bw.docbook
> editor-color-correction.docbook
> editor-color-curves.docbook
> editor-color.docbook
> editor-color-exposure.docbook
> editor-color-levels.docbook
> editor-color-mixer.docbook
> editor-color-neg.docbook
> editor-color-wb.docbook
> editor-decorate-border.docbook
> editor-decorate.docbook
> editor-decorate-inserttext.docbook
> editor-decorate-texture.docbook
> editor-enhance-blur.docbook
> editor-enhance-distortion.docbook
> editor-enhance.docbook
> editor-enhance-hotpixels.docbook
> editor-enhance-inpaint.docbook
> editor-enhance-lenscorrection.docbook
> editor-enhance-localcontrast.docbook
> editor-enhance-nr.docbook
> editor-enhance-redeyes.docbook
> editor-enhance-restoration.docbook
> editor-enhance-sharpen.docbook
> editor-enhance-vignetting.docbook
> editor-filters-blurfx.docbook
> editor-filters-charcoal.docbook
> editor-filters-colorsfx.docbook
> editor-filters-distortionfx.docbook
> editor-filters.docbook
> editor-filters-emboss.docbook
> editor-filters-filmgrain.docbook
> editor-filters-oilpaint.docbook
> editor-filters-raindrops.docbook
> editor-photoediting.docbook
> editor-transform-crop.docbook
> editor-transform.docbook
> editor-transform-freerotation.docbook
> editor-transform-liquid.docbook
> editor-transform-perspective.docbook
> editor-transform-resize.docbook
> editor-transform-rotateflip.docbook
> editor-transform-shear.docbook
> editor-using.docbook
> index.docbook
> intro-background.docbook
> intro-camerasupport.docbook
> intro-contrib.docbook
> intro-database.docbook
> intro-firstrun.docbook
> intro-imageformats.docbook
> intro-info.docbook
> intro-movieformats.docbook
> intro-pluginsupport.docbook
> menu-bqm.docbook
> menu-camera.docbook
> menu-editor.docbook
> menu-lighttable.docbook
> menu-mainwindow.docbook
> tool-acquireimages.docbook
> tool-advrename.docbook
> tool-calendar.docbook
> tool-dropbox.docbook
> tool-expoblending.docbook
> tool-facebook.docbook
> tool-findduplicates.docbook
> tool-flashexport.docbook
> tool-flickrexport.docbook
> tool-geolocationeditor.docbook
> tool-googleexport.docbook
> tool-imageshack.docbook
> tool-imgur.docbook
> tool-kmlexport.docbook
> tool-maintenance.docbook
> tool-mediawiki.docbook
> tool-metadataeditor.docbook
> tool-panorama.docbook
> tool-piwigoexport.docbook
> tool-presentation.docbook
> tool-printwizard.docbook
> tool-rajce.docbook
> tool-remotestorage.docbook
> tool-sendimages.docbook
> tool-smug.docbook
> tool-vkontakte.docbook
> tool-yandexfotki.docbook
> using-bqm.docbook
> using-camera-basis.docbook
> using-camera.docbook
> using-camera-gps.docbook
> using-camera-intro.docbook
> using-camera-processing.docbook
> using-dam-build.docbook
> using-dam-copyright.docbook
> using-dam-corruption.docbook
> using-dam.docbook
> using-dam-intro.docbook
> using-dam-workflow.docbook
> using-lighttable.docbook
> using-mainwindow-albumsview.docbook
> using-mainwindow-datesview.docbook
> using-mainwindow.docbook
> using-mainwindow-fuzzysearches.docbook
> using-mainwindow-imageview.docbook
> using-mainwindow-intro.docbook
> using-mainwindow-labelsview.docbook
> using-mainwindow-peopleview.docbook
> using-mainwindow-searchesview.docbook
> using-mainwindow-tagsview.docbook
> using-mainwindow-timelineview.docbook
> using-setup-album.docbook
> using-setup-camera.docbook
> using-setup-cm.docbook
> using-setup-collections.docbook
> using-setup-database.docbook
> using-setup.docbook
> using-setup-editor-iface.docbook
> using-setup-editor-raw.docbook
> using-setup-editor-save.docbook
> using-setup-editor-version.docbook
> using-setup-intro.docbook
> using-setup-lighttable.docbook
> using-setup-metadata.docbook
> using-setup-metadata-intro.docbook
> using-setup-metadata-rotation-ac.docbook
> using-setup-metadata-views.docbook
> using-setup-mimetype.docbook
> using-setup-misc-behavior.docbook
> using-setup-misc.docbook
> using-setup-plugins.docbook
> using-setup-quality.docbook
> using-setup-slideshow.docbook
> using-setup-templates.docbook
> using-setup-theme.docbook
> using-setup-tooltip.docbook
> using-sidebar-captions.docbook
> using-sidebar-colors.docbook
> using-sidebar.docbook
> using-sidebar-filters.docbook
> using-sidebar-intro.docbook
> using-sidebar-maps.docbook
> using-sidebar-metadata.docbook
> using-sidebar-properties.docbook
> using-sidebar-tools.docbook
> using-tagsmngr.docbook
> 
> ... my script is not broken...
> 
> Gilles Caulier

All those files are available for uk:
https://websvn.kde.org/trunk/l10n-kf5/uk/docs/extragear-graphics/digikam/

Please recheck.
Comment 12 caulier.gilles 2016-09-25 16:39:00 UTC
hum, i take a look...

Gilles Caulier
Comment 13 caulier.gilles 2016-09-25 17:39:35 UTC
Git commit 7f6f80e2a7f10206c9c9ca70a4cb80eac16ccd68 by Gilles Caulier.
Committed on 25/09/2016 at 17:38.
Pushed by cgilles into branch 'master'.

fix doc i18n extract about typo with docbook file extension and list of files to checkout.

M  +1    -1    bootstrap.linux
M  +27   -24   project/release/fetch_l10n_doc.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/7f6f80e2a7f10206c9c9ca70a4cb80eac16ccd68
Comment 14 caulier.gilles 2016-09-25 17:43:05 UTC
Sound like only UK and NL translations files are complete :

-- Extract documentation translation files from git repositories. Please wait, it can take a while...
-- NOTE: (u) want mean uncomplete translations files, which will be removed from compilation.
digikam: af(u) ar(u) az(u) be(u) bg(u) bn(u) br(u) bs(u) ca(u) cs(u) csb(u) cy(u) da(u) de(u) el(u) en_GB(u) eo(u) es(u) et(u) eu(u) fa(u) fi(u) fo(u) fr(u) fy(u) ga(u) gl(u) ha(u) he(u) hi(u) hr(u) hsb(u) hu(u) id(u) is(u) it(u) ja(u) ka(u) kk(u) km(u) ko(u) ku(u) lb(u) lo(u) lt(u) lv(u) mi(u) mk(u) mn(u) ms(u) mt(u) nb(u) nds(u) ne(u) nl nn(u) nso(u) oc(u) pa(u) pl(u) pt(u) pt_BR(u) ro(u) ru(u) rw(u) se(u) sk(u) sl(u) sq(u) sr(u) sr@Latn(u) ss(u) sv(u) ta(u) te(u) tg(u) th(u) tr(u) tt(u) uk uz(u) uz@cyrillic(u) ven(u) vi(u) wa(u) xh(u) zh_CN(u) zh_HK(u) zh_TW(u) zu(u) 
showfoto: nl uk 
-- Documentation translation files extraction done.

Gilles Caulier
Comment 15 Luigi Toscano 2016-09-25 17:50:31 UTC
(In reply to caulier.gilles from comment #14)
> Sound like only UK and NL translations files are complete :

It's a start :)
Comment 16 caulier.gilles 2016-09-25 17:51:10 UTC
Both compile fine anyway  :

[gilles@localhost doc-translated]$ make
Scanning dependencies of target doc-translated-nl-digikam-index-cache-bz2
[100%] Generating digikam/index.cache.bz2
[100%] Built target doc-translated-nl-digikam-index-cache-bz2
Scanning dependencies of target doc-translated-nl-showfoto-index-cache-bz2
[100%] Generating showfoto/index.cache.bz2
[100%] Built target doc-translated-nl-showfoto-index-cache-bz2
[100%] Generating digikam/index.cache.bz2
[100%] Built target doc-translated-uk-digikam-index-cache-bz2
[100%] Generating showfoto/index.cache.bz2
[100%] Built target doc-translated-uk-showfoto-index-cache-bz2

[gilles@localhost doc-translated]$
Comment 17 caulier.gilles 2016-09-27 18:35:53 UTC
Git commit 6992e99ce8362c3bef5840f1969de568b109c0b1 by Gilles Caulier.
Committed on 27/09/2016 at 18:32.
Pushed by cgilles into branch 'master'.

extraction of list of handbook files is done automatically, parsing documentation git repository contents
The documentation translations can be now included in next tarball release 5.3.0
FIXED-IN: 5.3.0
CCMAIL: neoclust.kde@gmail.com

M  +10   -160  project/release/fetch_l10n_doc.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/6992e99ce8362c3bef5840f1969de568b109c0b1