Bug 369307

Summary: Wrong find command in file validate_svg.sh
Product: [Plasma] Breeze Reporter: Alexander Reinholdt <alexander.reinholdt>
Component: IconsAssignee: visual-design
Status: RESOLVED FIXED    
Severity: normal CC: kainz.a, sitter
Priority: NOR    
Version First Reported In: 5.7.95   
Target Milestone: ---   
Platform: Other   
OS: FreeBSD   
Latest Commit: Version Fixed In: 5.27
Sentry Crash Report:
Attachments: Patch that fixes the described failure

Description Alexander Reinholdt 2016-09-25 07:18:20 UTC
When compiling from source under FreeBSD using ports with the plasma5 branch from area51 merged, compilation of the package breeze-icons fails with an 'illegal command' error, due to a wrong find command line in the validate_svg.sh file. (See additional information section for a patch.)

Reproducible: Always

Steps to Reproduce:
Compile breeze-icons from source under FreeBSD.

Actual Results:  
Fails with an 'illegal command' error.

Expected Results:  
Compiles successfully.

The following patch fixes the problem:

diff --git a/validate_svg.sh b/validate_svg.sh
index bbc3076..adaf26f 100644
--- a/validate_svg.sh
+++ b/validate_svg.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-find -name '*.svg' -exec xmllint --noout {} + 2> xmlerrors
+find . -name '*.svg' -exec xmllint --noout {} + 2> xmlerrors
 if [ -s xmlerrors ]; then
     cat xmlerrors
     rm xmlerrors
Comment 1 Alexander Reinholdt 2016-09-25 07:20:14 UTC
Created attachment 101269 [details]
Patch that fixes the described failure
Comment 3 Harald Sitter 2016-09-26 10:07:39 UTC
For future reference. Review Board is (currently) the place to put patches, they easily get lost in the bug tracker https://community.kde.org/Infrastructure/Review_Board