Summary: | LessCSS syntax problem | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-syntax-highlighting | Reporter: | Jaime Torres <jtamate> |
Component: | syntax | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | cyberbeat, gszymaszek, thomas |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/syntax-highlighting/ca846fbda3185f1c13cb0e423631033d64c2ff7b | Version Fixed In: | |
Sentry Crash Report: |
Description
Jaime Torres
2016-09-24 10:06:13 UTC
I can confirm this. I have some expression like @media (max-width: @width2) { height:auto; .. } and after the variable @width2 the syntax highlighting is broken. Many changes went into CSS and SCSS just today, see: https://git.reviewboard.kde.org/r/128925/ LESSCSS was once copied from CSS. So many of the changes should probably also be applied to less.xml. Can one of you here do this? We would happily accept a patch. Sorry, but this bug is something less-specific, so I think it will not be fix by applying the changes from css. And I have to admit, that I looked once on the xml files, and did not catch it. Stumbled upon this as well. Media queries containing variables are getting highlighted as errors. Regular media queries containing just numbers do work fine. Since there are no variables in regular CSS, this issue is LESS specific. @Thomas Holzeisen, I’m working on adapting current SCSS syntax definitions to Less. Most of the work is done, but I have to fix variable interpolation inside properties, for example `a { @{someStringLikeBackground}-color: red; }`. I seems this indeed is still an issue. While CSS and SCSS got huge updates to fix this, LessCSS still has this issue. Can anyone look into this who is using LessCSS and provide a fix? Maybe the changes done to SCSS and CSS can act as reference: https://bugs.kde.org/show_bug.cgi?id=376005 This bug is fixed in https://phabricator.kde.org/D5799 Git commit ca846fbda3185f1c13cb0e423631033d64c2ff7b by Grzegorz Szymaszek. Committed on 19/08/2017 at 08:35. Pushed by gszymaszek into branch 'master'. Rebased Less syntax highlighting on SCSS one Differential Revision: https://phabricator.kde.org/D5799 A +701 -0 autotests/input/highlight.less M +559 -191 data/syntax/less.xml https://commits.kde.org/syntax-highlighting/ca846fbda3185f1c13cb0e423631033d64c2ff7b |