Summary: | Crash if I use next/previous key frame quickly (back and forth) and draw at the same time | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | portfolioval |
Component: | Animation | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | animtim, halla, joupent, scottpetrovic |
Priority: | NOR | ||
Version: | 3.0.1 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/krita/4ae6ff72311d9b1a97f7e71f4a0adf0d1127064e | Version Fixed In: |
Description
portfolioval
2016-09-22 12:25:26 UTC
What graphics cards are in those systems? And could you check the 3.0.2 alpha, too? http://download.kde.org/unstable/krita/3.0.1.89/ I confirm I can somehow reproduce on linux, with intel graphics: if I change frame while stylus is still drawing on the canvas, krita completely freeze. I just got this crash pretty quickly on the latest windows build. 3.0.1.90 Followed the steps pretty much perfectly and it happened withing a second or two as soon as I started painting on the canvas. For a graphics card, I have an NVIDIA GT650 The desktop computer have a NVIDIA GeForce GTX 660 graphic card and the laptop have two graphic cards a Intel (R) HD Graphics 530 and a nvidia (I have to check again for the nvidia graphic to be more precise ) I've downloaded the alpha but I didn't undestand how to install it . I can't replicate the problem with the default shortcuts, but it does happen here with custom ones. Looking at it in a debugger, seems like the scheduler gets stuck in a loop at: 1 KisUpdateScheduler::barrierLock kis_update_scheduler.cpp 335 0x7ffff3d37aec 2 KisImage::barrierLock kis_image.cc 411 0x7ffff3d47d98 3 KisImageAnimationInterface::switchCurrentTimeAsync kis_image_animation_interface.cpp 167 0x7ffff3d447d6 4 QMetaObject::activate(QObject *, int, int, void * *) 0x7ffff6f2d35e 5 KisImageAnimationInterface::sigInternalRequestTimeSwitch moc_kis_image_animation_interface.cpp 247 0x7ffff3e5f3c1 6 KisImageAnimationInterface::requestTimeSwitchNonGUI kis_image_animation_interface.cpp 160 0x7ffff3d44525 7 KisSwitchCurrentTimeCommand::redo kis_switch_current_time_command.cpp 60 0x7ffff3cb3cf0 8 KisImageAnimationInterface::requestTimeSwitchWithUndo kis_image_animation_interface.cpp 144 0x7ffff3d44372 9 AnimationDocker::slotNextFrame animation_docker.cpp 390 0x7fffaf215fc5 (...) OK so my laptop has a Nvidia GeForce GTX 950M (for applications I guess) and Intel (R) HD Graphics 530 (for desktop If my understanding is good) Git commit 7ade2d46b4c7e6411d0175c4cf8621c83b01a06e by Dmitry Kazakov. Committed on 17/10/2016 at 12:21. Pushed by dkazakov into branch 'master'. Fix switching frames when painting at the same time Fixes T3930 M +1 -0 libs/image/CMakeLists.txt M +5 -5 libs/image/commands_new/kis_switch_current_time_command.cpp M +4 -2 libs/image/commands_new/kis_switch_current_time_command.h M +62 -34 libs/image/kis_image_animation_interface.cpp M +7 -4 libs/image/kis_image_animation_interface.h A +78 -0 libs/image/kis_switch_time_stroke_strategy.cpp [License: GPL (v2+)] A +53 -0 libs/image/kis_switch_time_stroke_strategy.h [License: GPL (v2+)] M +37 -0 libs/image/tests/kis_image_animation_interface_test.cpp M +1 -1 libs/image/tests/kis_image_animation_interface_test.h M +1 -1 plugins/dockers/animation/animation_docker.cpp M +1 -1 plugins/dockers/animation/kis_time_based_item_model.cpp M +1 -1 plugins/dockers/animation/tests/timeline_model_test.cpp M +1 -1 plugins/dockers/defaultdockers/kis_layer_box.cpp http://commits.kde.org/krita/7ade2d46b4c7e6411d0175c4cf8621c83b01a06e Git commit 4ae6ff72311d9b1a97f7e71f4a0adf0d1127064e by Dmitry Kazakov. Committed on 17/10/2016 at 12:21. Pushed by dkazakov into branch 'master'. Make the frame switch stroke a barrier Now the frame cannot switch until all the background strokes are finished. Basically, we had this behavior from the very beginning, though I wanted to get out of it, but it didn't work. Fixes T3930 M +3 -5 libs/image/kis_image_animation_interface.cpp M +9 -4 libs/image/kis_switch_time_stroke_strategy.cpp http://commits.kde.org/krita/4ae6ff72311d9b1a97f7e71f4a0adf0d1127064e |