Bug 369169

Summary:	ppc64 fails jm_int_isa_2_07 test
Product:	[Developer tools] valgrind	Reporter:	Mark Wielaard <mark>
Component:	vex	Assignee:	Julian Seward <jseward>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cel
Priority:	NOR
Version:	3.12 SVN
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	test output diff with expected output diff with LE expected output fix for jm_int_isa_2_07.

Description Mark Wielaard 2016-09-21 18:27:42 UTC

On ppc32 and ppc64le the jm_int_isa_2_07 test passes.
But on ppc64[be] ./none/tests/ppc64/jm_int_isa_2_07.stdout.out doesn't match either the jm_int_isa_2_07.stdout.exp or jm_int_isa_2_07.stdout.exp-LE

This system has:
gcc-4.8.5-11.el7.ppc64
binutils-2.25.1-22.base.el7.ppc64
glibc-2.17-157.el7.ppc64
glibc-2.17-157.el7.ppc
kernel-3.10.0-508.el7.ppc64

processor       : 0
cpu             : POWER8 (architected), altivec supported
clock           : 3425.000000MHz
revision        : 2.1 (pvr 004b 0201)

timebase        : 512000000
platform        : pSeries
model           : IBM,8247-22L
machine         : CHRP IBM,8247-22L

Reproducible: Always

Comment 1 Mark Wielaard 2016-09-21 18:31:16 UTC

Created attachment 101218 [details]
test output

Comment 2 Mark Wielaard 2016-09-21 18:32:37 UTC

Created attachment 101219 [details]
diff with expected output

Comment 3 Mark Wielaard 2016-09-21 18:34:38 UTC

Created attachment 101220 [details]
diff with LE expected output

Comment 4 Mark Wielaard 2016-09-21 18:43:56 UTC

The diffs are the same because the none/tests/ppc64/jm_int_isa_2_07.stdout.exp and none/tests/ppc64/jm_int_isa_2_07.stdout.exp-LE expect files are the same.

Comment 5 Carl Love 2016-09-21 23:31:25 UTC

Created attachment 101221 [details]
fix for jm_int_isa_2_07.

The none/tests/ppc64/jm_int_isa_2_07.stdout.exp, by convention, should have the big endian results.  The current file contains the little endian results.  By convention, the little endian result files have "-LE" appended to the expected output file name.  This patch fixes the output in the  none/tests/ppc64/jm_int_isa_2_07.stdout.exp file.  

The results of the regression test on pre Power 8 processors and Power 8 LE processors should not change.

Please test the patch and see if the regression test results are as expected on your machine.

Comment 6 Mark Wielaard 2016-09-22 08:07:24 UTC

(In reply to Carl Love from comment #5)
> Please test the patch and see if the regression test results are as expected
> on your machine.

They PASS. Thanks.

Comment 7 Carl Love 2016-09-22 15:39:25 UTC

patch committed valgrind commit 15977