Summary: | ext_qt (5.7) build fails with Xcode 8 + macOS Sierra | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Patrice Kouame <pkouame> |
Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | halla |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | macOS | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
patches defaults_pre.prf
patches qtbase configure cmake fix for invalid module qtenginio |
Description
Patrice Kouame
2016-09-21 15:39:03 UTC
Created attachment 101212 [details]
patches defaults_pre.prf
in qtbase/mkspecs/features/mac
Created attachment 101213 [details]
patches qtbase configure
ALSO : qteginio no longer a valid module ... patch to ext_qt/CMakelists.txt is attached only tweaked and tested the mac portion though... Created attachment 101214 [details]
cmake fix for invalid module qtenginio
Geez hate not being able to edit/correct these (at least haven't found a way how), but I meant 5.7.1 may fix this...still confirming Okay. If you've got a patch that works, and that also doesn't break building with the with the 10.9 sdk, could you put it on phabricator? Ok will do. Shouldn't break 10.9sdk and have been running master with it for a while. Actually patched QT5.7 very early on during xcode betas and just forgot about it until now. We'll have to look out for 5.7.1 and its impact (at least on macOS) FYI, got a response from the qt guys about their weird warnings (mostly java related). We can ignore these for the moment. In fact do we even need java script core? I think not. There must a be a -skip for it. Let me check. Hate bloat. Interesting response... >...some of these look genuinely scary. > >everything from 3rdparty/javascriptcore is mostly irrelevant to us. we may resolve this by upgrading jsc at some point (this has been discussed within the >scope of the qbs project, which still uses the (deprecated) qtscript module), but it's not a priority." [QTBUG-56120](https://bugreports.qt.io/browse/QTBUG-56120 "QTBUG-56120") The qtscript module is used by ki18n, so we need that, but we can and should skip webkit and qtwebengine. We need qtdeclarative to be able to build qttools. Did we already push this? Not yet. But since D2899 is accepted, will do so tonight. Yay! Closing then. |