Bug 369080

Created attachment 101190 [details]
Screen capture

This screen capture shows the hoops you have to jump through to select a resolution that is not on the list of approved presolutions.... 

It also shows just how much of a performance advantage you get when using a lower resolution for the project.

Evert, wouldn't the existing proxies technology achieve what you are aiming at using low resolution profiles?

Wegwerf, please look at the video I attached to the ticket. 

As you can see, I am using proxies, at a very low resolution. When encountering a deep effects stack, the preview window performance slows down unacceptably. 

Changing nothing but the project resolution, the preview window now performs acceptably. This means that the preview window can be sped up massively by being tricked into using the proxy resolution rather than the project resolution, and this is my suggestion. ( And an old one at that, however, this is not what this ticket is about. )

In order for me to get some reasonable performance out of my system, I set project resolution to be the same as my proxy resolution, and then do all my edits, and then set it back to my desired output resolution before rendering. 

In changing the project resolution, I found it cumbersome to keep changing to a resolution that is not on the short list. I would like a way to pick my favorite resolutions from the list of resolutions that are already defined. That is what this ticket is about. 

Kind regards,
Evert

Evert, thanks for clarifying!

Evert - On which Kdenlive version you made this screen grab? Looks like 18.12.

Intersting finding that the clips/proxy and effects are not proper scaled down in the timeline for playback.

Similar issue here: https://invent.kde.org/kde/kdenlive/issues/198. 

I think we discussed ones if we should do the playback view just on ½ or ¼ of the original size to speed up the playback.

Hi Evert, 

Would like to do some testing with your recomendations. The thing is I haven't seen any improvements... is there a performance improvement for you in the 19.08 series?

So it took a few years but the requirements for this were just implemented in MLT so get ready for that speed improvment :)

Monitor preview scaling is now implemented in git master (requires MLT from recent git or >= 6.20). You now have a menu in "Monitor > Preview Resolution" that allows you to work full resolution, 1/2 resolution, 1/4 or 1/8.

Feedback on performance is welcome

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Hi there!

I am getting a build error when trying to build the master branch of kdenlive:

-----------------------snip---------------------
[  3%] Building C object src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/mediactrl.c.o
/data/OS/aur/kdenlive-testing-git/src/kdenlive/src/lib/external/media_ctrl/mediactrl.c: In function 'find_first_device':
/data/OS/aur/kdenlive-testing-git/src/kdenlive/src/lib/external/media_ctrl/mediactrl.c:355:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
  355 |     for (int i = 0; i < 32; i++) {
      |     ^~~
/data/OS/aur/kdenlive-testing-git/src/kdenlive/src/lib/external/media_ctrl/mediactrl.c:355:5: note: use option '-std=c99', '-std=gnu99', '-std=c11' or '-std=gnu11' to compile your code
make[2]: *** [src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/build.make:76: src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/mediactrl.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2267: src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
Error making: kdenlive-testing-git

(In reply to Evert Vorster from comment #10)
> Hi there!
> 
> I am getting a build error when trying to build the master branch of
> kdenlive:
> 
> -----------------------snip---------------------
> [  3%] Building C object
> src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/mediactrl.c.o
> /data/OS/aur/kdenlive-testing-git/src/kdenlive/src/lib/external/media_ctrl/
> mediactrl.c: In function 'find_first_device':
> /data/OS/aur/kdenlive-testing-git/src/kdenlive/src/lib/external/media_ctrl/
> mediactrl.c:355:5: error: 'for' loop initial declarations are only allowed
> in C99 or C11 mode
>   355 |     for (int i = 0; i < 32; i++) {
>       |     ^~~
> /data/OS/aur/kdenlive-testing-git/src/kdenlive/src/lib/external/media_ctrl/
> mediactrl.c:355:5: note: use option '-std=c99', '-std=gnu99', '-std=c11' or
> '-std=gnu11' to compile your code
> make[2]: ***
> [src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/build.make:76:
> src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/mediactrl.c.o] Error 1
> make[1]: *** [CMakeFiles/Makefile2:2267:
> src/lib/external/media_ctrl/CMakeFiles/media_ctrl.dir/all] Error 2
> make: *** [Makefile:130: all] Error 2
> ==> ERROR: A failure occurred in build().
>     Aborting...
> Error making: kdenlive-testing-git


Hi Evert, 

Have you seen this: https://community.kde.org/Kdenlive/Development#Building_Kdenlive 

Try deleting CMakeCache.txt and run cmake again.

Hope that helps...

Ah, I was building the wrong branch of Kdenlive, my fault. I'll go test this feature now, and finally close this bug!

Right, I finally built kdenlive. I have to say, a very, very clean build with almost no error messages thrown by the compiler. 

The improvement of this scaling of the preview window is immediate and impressive. Thanks. I can now use 4K drone footage without proxies, defish and levels adjust on the fly, too. (Pun intended)

I'll go ahead and close this bug, now. There are some issues with the preview monitor scaling, but I will report that separately.