Bug 369048

Summary: [packaging] kwin: Optionally depend on libhybris-dev for armhf and enable hwcomposer plugin
Product: [KDE Neon] neon Reporter: Bhushan Shah <bshah>
Component: generalAssignee: Neon Bugs <neon-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: jr, neon-bugs-null, sitter
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Bhushan Shah 2016-09-19 12:23:57 UTC 
Currently kwin packaging doesn't depend on libhybris and doesn't build hwcomposer.. and for mobile we use patched packaging in Neon/mobile branch to enable it : 

https://packaging.neon.kde.org/plasma/kwin.git/commit/?h=Neon/mobile&id=ba779ae41aed29e011eb693e51c895d8e82aa511

It would be sensible to have Neon/release, Neon/stable branches to depend on libhybris-dev on armhf architecture and enable hwcomposer platform packages so that it can be used by Debian CI as well..

Reproducible: Always
Comment 1 Bhushan Shah 2016-09-19 12:28:55 UTC 
17:55 <shadeslayer> won't Neon have to build their own hybris?
17:55 <Riddell> shouldn't be a problem
17:56 <Riddell> as we don't build for arm in neon it won't affect the neon buids
17:56 <Riddell> go ahead
17:56 <shadeslayer> true

Waiting for day if there are objections, otherwise will push change.
Comment 2 Jonathan Riddell 2016-09-19 12:41:11 UTC 
shouldn't be a problem
build-deps can be made arch only with [armhf]
install files are be made arch only  debian/kwin-thing.install.armhf
needs some Makefile/bash ugly syntax in debian/rules if it needs different cmake arguments
and the package is empty when built on amd64
Comment 3 Bhushan Shah 2016-09-19 12:45:43 UTC 
(In reply to Jonathan Riddell from comment #2)
> install files are be made arch only  debian/kwin-thing.install.armhf

Since there is "Architecture: armel armhf", it won't be required.. am I correct?

> needs some Makefile/bash ugly syntax in debian/rules if it needs different
> cmake arguments

No cmake arguments are required.. so we are safe :-P
Comment 5 Harald Sitter 2016-09-20 07:04:37 UTC 
If the package is armhf and armel, so needs the build-dep (currently only armhf)
Comment 6 Bhushan Shah 2016-09-20 07:39:05 UTC 
Okay, I will make that change.. however I've another question, can I add same patch in Neon/release branch?
Comment 7 Harald Sitter 2016-09-20 08:22:46 UTC 
No clue, probably.