Bug 368949

Summary:	foo.desktop: Terminal=true no longer works with konsole-16.08.1
Product:	[Unmaintained] kio	Reporter:	Rex Dieter <rdieter>
Component:	desktop	Assignee:	Fredrik Höglund <fredrik>
Status:	RESOLVED FIXED
Severity:	major	CC:	arojas, phillb
Priority:	NOR	Keywords:	regression
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	c784a879eaba0babc6274bc32e761772add3d4f8	Version Fixed/Implemented In:
Sentry Crash Report:

Description Rex Dieter 2016-09-17 13:59:03 UTC

I've a sample application shortcut that runs in a terminal, bc.desktop, that contains:
[Desktop Entry]
Name=bc
Exec=/usr/bin/bc
Terminal=true
Type=Application

This has always worked as expected, to run terminal app 'bc' inside a konsole.  After upgrading to konsole-16.08.1, this no longer works.  Now when I click the application link, nothing happens



Reproducible: Always

Comment 1 Rex Dieter 2016-09-17 14:00:42 UTC

See also downstream report,
https://bugzilla.redhat.com/show_bug.cgi?id=1376981

Comment 2 Rex Dieter 2016-09-17 14:04:02 UTC

Quick-n-dirty cli test:

kioclient5 exec bc.desktop

Comment 3 Rex Dieter 2016-09-17 14:34:03 UTC

So, kio contains this code:

    if (d->service.terminal()) {
        KConfigGroup cg(KSharedConfig::openConfig(), "General");
        QString terminal = cg.readPathEntry("TerminalApplication", QStringLiteral("konsole"));
        if (terminal == QLatin1String("konsole")) {
            if (!d->service.path().isEmpty()) {
                terminal += " --workdir " + KShell::quoteArg(d->service.path());
            }
            terminal += QLatin1String(" -caption=%c %i %m");
        }


And konsole seems to no longer support the -caption command line option,
$ konsole  -caption="foo"
Unknown options: c, a.

Comment 4 Rex Dieter 2016-09-17 14:35:27 UTC

And, that seems to be related to bug #366793  :(

Comment 5 Antonio Rojas 2016-09-17 14:43:42 UTC

Already fixed in c784a879eaba0babc6274bc32e761772add3d4f8

Comment 6 Rex Dieter 2016-09-17 14:59:57 UTC

Thanks!

Comment 7 Antonio Rojas 2016-09-26 06:08:19 UTC

*** Bug 369371 has been marked as a duplicate of this bug. ***