Bug 368912

Summary: Apps menu and its tooltip must use the same icon when user sets a customized menu icon
Product: [Plasma] plasmashell Reporter: Patrick Silva <bugseforuns>
Component: Application Menu (Kicker)Assignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: minor CC: kde, kde, notmart, plasma-bugs
Priority: LO    
Version: 5.7.95   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: screenshot

Description Patrick Silva 2016-09-16 20:16:58 UTC 
This affects both kickoff and classic menu.

Reproducible: Always

Steps to Reproduce:
1.right click on apps menu icon, select "Application launcher settings"
2.choose any customized icon and apply the change
3.

Actual Results:  
kde menu and its tooltip have different icons. See the screenshot please.

Expected Results:  
kde menu and its tooltip have the same icon.
Comment 1 Patrick Silva 2016-09-16 20:17:42 UTC 
Created attachment 101129 [details]
screenshot
Comment 2 Kai Uwe Broulik 2016-09-17 12:28:38 UTC 
This works with Kickoff, re-assigning to Kicker (which is actually shown in the screenshot).
Comment 3 Eike Hein 2016-09-17 14:15:14 UTC 
This is because Kicker uses a custom compact representation that uses an Image instead of an IconItem when asked to display a custom button image, because IconItem does not support non-square images. To fix it it would need a custom tooltip delegate as well, which would then predictably go out of sync with the standard one eventually, causing different visual issues.

I seem to vaguely recall another tooltip-related(?) problem due to the custom compact repr that I talked about with Marco, and I think we determined the only way to fix it was to move the TooltipArea into the custom repr, but I don't really recall what it was anymore. Maybe it was Kicker not using the Widget Explorer applet icon as tooltip icon, as we tried in the standard delegate for a while (but then abandoned), although I don't see how that would break. Or it was something related to mouse state. I think we noticed it with App Dash. Anyways ...

The only fix to this is currently to ugly to implement, so it's a WONTFIX unless that situation changes.
Comment 4 Kai Uwe Broulik 2017-01-05 15:54:18 UTC 
Now that IconItem can display non-square icons...?
Comment 5 Eike Hein 2017-01-06 05:24:56 UTC 
Too late for 5.9 imho, remind me for 5.10 and we can try.
Comment 6 David Edmundson 2017-01-22 21:37:57 UTC 
Pushed with f37c2ea93dd011c2a2dd6bbd648e60d36fa36a51