Bug 368730

Summary:	css syntax highlighting doesn't recognize attribute "local" in "background-attachment:local;"
Product:	[Applications] kate	Reporter:	Peter Möller <gorgonz>
Component:	syntax	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	15.12
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/syntax-highlighting/f92238c5cd210b4887fbd9f0c9cfe153361f292b	Version Fixed In:	KDE Frameworks 5.32
Sentry Crash Report:
Attachments:	example code for faster debugging

Description Peter Möller 2016-09-13 07:40:33 UTC

the first not recognized character is ';'. so all following lines will be rendered as red text.

Here is the syntax rule from w3school:
background-attachment: scroll|fixed|local|initial|inherit;

Short test of all attributes shows:
- scroll: ok
- fixed: ok
- local: highlighted, but more characters are expected, which? i don't know
- initial: recognized, but uncolored
- inherit: ok

Reproducible: Always

Comment 1 Peter Möller 2016-09-13 07:44:35 UTC

Created attachment 101065 [details]
example code for faster debugging

Comment 2 Dominik Haumann 2017-02-12 19:08:24 UTC

Git commit f92238c5cd210b4887fbd9f0c9cfe153361f292b by Dominik Haumann.
Committed on 12/02/2017 at 19:07.
Pushed by dhaumann into branch 'master'.

Update SCSS and CSS syntax highlight

Changes:
- Use less and more simple context rules.
- Support complex SCSS structures, e.g. variables in @media, nesting, variable define.
- Support SCSS functions.
- Support CSS @keyframes structure and @media conditions.
- Different highlight colors for id, class, attribute and pseudo selectors.
- Reduce highlight errors.

FIXED-IN: KDE Frameworks 5.32
REVIEW: 128925
Related: bug 376005

M  +2    -2    autotests/folding/highlight.css.fold
M  +8    -8    autotests/folding/review128925-1.css.fold
M  +28   -28   autotests/folding/review128925-1.scss.fold
M  +5    -5    autotests/folding/review128925-2.css.fold
M  +14   -14   autotests/folding/review128925-2.scss.fold
M  +41   -41   autotests/html/highlight.css.html
M  +57   -57   autotests/html/review128925-1.css.html
M  +132  -132  autotests/html/review128925-1.scss.html
M  +20   -20   autotests/html/review128925-2.css.html
M  +35   -35   autotests/html/review128925-2.scss.html
M  +6    -6    autotests/html/test.css.html
M  +2    -2    autotests/html/test.htm.html
M  +30   -30   autotests/reference/highlight.css.ref
M  +56   -56   autotests/reference/review128925-1.css.ref
M  +131  -131  autotests/reference/review128925-1.scss.ref
M  +19   -19   autotests/reference/review128925-2.css.ref
M  +34   -34   autotests/reference/review128925-2.scss.ref
M  +6    -6    autotests/reference/test.css.ref
M  +2    -2    autotests/reference/test.htm.ref
M  +79   -136  data/syntax/css.xml
M  +229  -171  data/syntax/scss.xml

https://commits.kde.org/syntax-highlighting/f92238c5cd210b4887fbd9f0c9cfe153361f292b

Comment 3 Dominik Haumann 2017-02-12 19:11:08 UTC

@Peter: The latest commit changed a lot. Can you please test again with KDE Frameworks 5.32? This will be released in the 2nd weekend of March 2017. If you still have problems then, please come back to us here. Thanks!