| Summary: | Wireless and aeroplane mode Oxygen icons missing in plasma-nm | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Dainius Masiliūnas <pastas4> |
| Component: | general | Assignee: | pinheiro <nuno> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bhush94, jgrulich, maxy, notmart, nuno, plasma-bugs, wbauer1 |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
plasma-nm screenshot
Comparison of network.svgz in Breeze and Air desktop themes Screenshot of Kickoff with the Air theme now Screenshot with the new icons |
||
|
Description
Dainius Masiliūnas
2016-09-11 20:29:43 UTC
Created attachment 101049 [details]
plasma-nm screenshot
humm I see them here in my distro... #note i did not make the air-plain one, but its pretty good I think this is not a icon bug, they are/were there... *** This bug has been marked as a duplicate of bug 352510 *** I saw the other bug, but I don't think these are the same bug. There they're talking about Breeze, while in my case the problem is with *not* Breeze, in other words, Air and Oxygen have this problem, Breeze and all the openSUSE themes do not (they all use Breeze icons). But all right, I can report this downstream and see if this is openSUSE-specific. the icons are there, can you reproduce it with breeze? if not its might be your opensuse not shipping those, some icon name change, some breakage in kde... any way oxygen-air wise those icons exyst. Sorry, this is not a downstream problem. And I don't think this is a duplicate of bug#352510 either. The icons are in fact missing in the Air and Oxygen desktop themes (upstream). See attached screenshot for a comparison between network.svgz in Air and Breeze, and you should easily see the problem... Created attachment 101207 [details]
Comparison of network.svgz in Breeze and Air desktop themes
can we point this bug to Marco Martin? We had the air plain icon in Air If the icon is there in the icon theme, then it might be a Plasma or plasma-nm issue. The network.svgz file itself is provided by plasma-framework, hm. In which case the product/component probably needs to be changed. (In reply to Dainius Masiliūnas from comment #11) > If the icon is there in the icon theme, then it might be a Plasma or > plasma-nm issue. It's not in the icon theme either. plasma-nm uses network-flightmode-on/network-flightmode-off and network-wireless-on/network-wireless-off as icons for the two mentioned buttons. I can find neither of those in the breeze nor oxygen icon themes... > The network.svgz file itself is provided by > plasma-framework, hm. Yes, this is part of the *desktop* theme. Plasma's behavior is as follows according to my experience: First, it tries to load the icon from network.svgz (in this case) from the configured *desktop* theme. If network.svgz does not exist, it uses network.svgz from the default *desktop* theme (breeze) instead. If network.svgz does exist but doesn't contain that specific icon, it tries to load it from the *icon* theme instead. So in this case, the icon should also be found if it was part of the icon theme, but it isn't either. The main problem is that the Air and Oxygen desktop themes haven't been updated/adjusted to changes in other parts of Plasma (and plasma-nm), they are incomplete. network.svgz was missing completely from those themes for a while, which would make it work. IOW, if you delete network.svgz, the icon would show up, taken from breeze. (In reply to pinheiro from comment #10) > http://wstaw.org/m/2016/09/21/plasma-desktopJi7326.png here This looks like KDE4. It worked there, yes. But this bug report is about Plasma5. PS: in KDE4 those particular icons were taken from icons/plasma-networkmanagement2.svgz it seems, but this file is missing in Plasma5/plasma-framework. Just copying over that file doesn't help, but it should not be difficult to add the missing icons from there to network.svgz I suppose... (In reply to Wolfgang Bauer from comment #14) > PS: in KDE4 those particular icons were taken from > icons/plasma-networkmanagement2.svgz it seems, but this file is missing in > Plasma5/plasma-framework. Actually this file was part of plasma-nm itself in KDE4, but apparently it has been decided to move the icons over to plasma-framework/network.svgz for Plasma5. It's here in git btw: https://quickgit.kde.org/?p=plasma-nm.git&a=tree&h=8a0acc5aa3c0081d71c3c01bcf9de29acad51b78&hb=c62c0cbf19f55d0598fc868563c22386c3db9355&f=applet%2Ficons so moved to plasma then Yea, either that or frameworks-plasma/libplasma, or most likely both (plasma-nm should fall back to the system icon theme and the plasma framework should actually contain these icons for the Oxygen/Air themes). Moving to plasmashell as I don't know where to report this problem, but I don't think that Oxygen plasma theme will be updated with new icons any time soon. That's the thing, the icons are already there. They exist and are installed. They're just not in the right place. That's why I said that frameworks-plasma/libplasma is probably the right place for the bug instead, that's the package that is supposed to put the icons in the right place... (In reply to Dainius Masiliūnas from comment #20) > That's the thing, the icons are already there. They exist and are installed. No, they are not. At least not in the Oxygen/Air desktop themes, and not in the oxygen icon theme either. They are only in the breeze desktop theme. plasma-framework is still the right place though IMHO, as the Oxygen/Air desktop themes are part of plasma-framework. Hm, true, I looked through the installed Oxygen icons and I can't find an æroplane icon among them. There is a wifi icon (under devices), but it is a bit different from the one used by Plasma. That's a bit weird, since the icons themselves do exist (in the KDE4 version of Plasma, and I thought I saw it in a fresh install of Leap too?). yes those icons were in the plasma theme and were using an svg id to find then unlike proper icons that are prerendered in to png's Actually they were provided by the KDE4 plasma-nm itself, as I already wrote. And I repeat, it should not be difficult to take them from there (they were designed for Air anyway which was the default in KDE4), and add them to the Plasma5/plasma-framework Oxygen/Air desktop themes. I suppose I will try to do that myself, if/when I find the time (maybe next weekend?). I haven't checked if the KDE4 icons are 100% complete in regards to Plasma5 (there may have been some additions), but it would definitely be an improvement. Btw, a fresh install of Leap would use breeze by default, so that's maybe why you saw them... ;-) currently making all the icons using breeze as a reference will push later From what I can find, all the Oxygen nm icons indeed were there at some point in time, see: https://forum.kde.org/viewtopic.php?f=285&t=119742 http://linux-os.net/plasma-nm-mejoras-en-la-usabilidad/ (And yea, I may have seen the Breeze icons, although I specifically changed the Plasma theme and the Klipper icon was a pair of scissors and not a clipboard...) yeap, some one broke it probably wile making the much more extensive nm breeze icons, the thing was that the nm icons were in 2 places before and then it moved to just one svg file, along all of this changes air them got broken for this, i'm making a new set of icons now should be ready this weekend Nice, thanks :) (In reply to Dainius Masiliūnas from comment #26) > From what I can find, all the Oxygen nm icons indeed were there at some > point in time Yes, in KDE4. As I wrote they were part of KDE4 plasma-nm itself. (In reply to Dainius Masiliūnas from comment #29) > Nice, thanks :) Yes, I'd like to thank as well. PS: I just noticed that the "Refresh" icon is missing as well. The icon used for that is view-refresh that is in view.svgz in Breeze, but not in Oxygen/Air. Would be good if that could be added as well... (In reply to Wolfgang Bauer from comment #30) > > Yes, in KDE4. > As I wrote they were part of KDE4 plasma-nm itself. The screenshots I linked at are not from KDE4 ("networkmanagement"), though, they're from the Plasma 5 redesign (plasma-nm), just before Breeze icons existed. (In reply to Dainius Masiliūnas from comment #32) > (In reply to Wolfgang Bauer from comment #30) > > > > Yes, in KDE4. > > As I wrote they were part of KDE4 plasma-nm itself. > > The screenshots I linked at are not from KDE4 ("networkmanagement"), though, They are. plasma-nm has been designed and released in KDE4 times already, replacing the older "networkmanagement". openSUSE shipped it in a pre-release version in 13.1 already (though plasmoid-networkmanagement was still installed by default), and as only option in 13.2. Both came with the KDE4 desktop. https://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=6b135f212c7907c5879c5b7c816de8638d44e4d4 so here done and finished, kinda redid them all http://wstaw.org/m/2016/10/10/plasma-desktopN27711.png *** Bug 370541 has been marked as a duplicate of this bug. *** I see the commit that adds the missing icons to Air. What about Oxygen? Also, the icon-themes (at least the ones in /usr/share/icons/*) are inheritable, wouldn't it make sense to inherit from default for air and oxygen desktopthemes? I don't maintain "oxygen" plasma theme (think we should remove it if its no one is maintaining it), that one as been kinda dead sine kde 4.3 wen it was replaced by air, as for Oxygen icon proper not sure, its a bit to much repeated icons that should be done differently by using overlays and similar tricks, I thinks that's the way we do it in many areas. As for the notwork manager inheriting the icons (png's) from the defout theme if the plams theme does not have it its makes sence to me, but again it shoud use overlays and and not the svg id's multiple copies (In reply to Maximiliano Curia from comment #36) > I see the commit that adds the missing icons to Air. What about Oxygen? Oxygen should get them "automatically". It has no icons itself, the Air icons are installed to the Oxygen theme as well. AFAICS, the "network-flightmode-on/off" (airplane) icons are still missing though. And "view-refresh" that is in view.svgz in Breeze, see comment#31. That is the green circled arrow in the KDE4 version, to rescan the wireless networks. OMG now I feel like an .... the entire reason for this was the plain icons I do them all and the one I forget... will comiit them later today .... what an.... fixed n pushing Created attachment 101560 [details] Screenshot of Kickoff with the Air theme now (In reply to pinheiro from comment #40) > fixed n pushing Great, thanks! But I saw that you changed "view-history" as well. I'm not sure that's a good idea, as this is used by Kickoff (the application launcher) as icon for the "History" tab (and only for that AFAICS). It looks a bit out of place now with the other Oxygen icons I fear, see attached screenshot. Unless you plan to rework those too of course. But then, I think many people that use Air/Oxygen prefer it over Breeze/Breeze-dark because of the more colorful icons... Although, in the end it's your decision of course. I just wanted to mention it. Wolfgang Bauer, you are absolutely right, looks horrible there.... not exactly my fault, the air icons are supposed to be minimalist wen applications mix oxygen icons in plasma are things can go wrong. Like an svg that is part of plasma theme having oxygen icons that cant even be well rendered by QT-SVG. (In reply to pinheiro from comment #42) > Wolfgang Bauer, you are absolutely right, looks horrible there.... not > exactly my fault, the air icons are supposed to be minimalist wen > applications mix oxygen icons in plasma are things can go wrong. Like an svg > that is part of plasma theme having oxygen icons that cant even be well > rendered by QT-SVG. I'm not sure we are talking about the same thing here. The new SVG is rendered fine, but as I understand it, those minimalist/monochromic icons are only to be used in the system tray, aren't they? But view-history is used by the application launcher, and the other icons are colorful as can be seen in my screenshot (exactly like they were in KDE4). That's the only thing I mean here. If Kickoff looks "horrible" to you, it may be because of bug#365204, in short some of the icons are "broken" currently and Plasma falls back to the icon theme then. Should not be a problem if you use the "Oxygen" icon theme though (that's what I did in my screenshot). My doubt is whether it's a good idea to replace view-history with a simplicistic version though instead of just keeping the old one. Wolfgang Bauer svg is a great format its what we used for oxygen icons, now there we used pretty much the full svg speck think blur filter multiply filters, masks, clippings etc, now qt svg renderer can only do a small portion of the svg wc3 speck, so if svg is the source for the rendering it needs to be simple, this made the distinction easy (plus the fact that svg rendering is not super fast), air stuff was to be minimal and simplistic were in oxygen iconography as we prerendered everything we could do what ever we wanted.... So if an svg plasma theme file contains a oxygen icon source that is bad and probably wont work well. i would much rather prefer that Kickoff looks for the oxygne png files in the size it wants, than trying to use an svg file. (In reply to pinheiro from comment #44) > So if an svg plasma theme file contains a oxygen icon source that is bad > and probably wont work well. i would much rather prefer that Kickoff looks > for the oxygne png files in the size it wants, than trying to use an svg > file. Ok. But the point is that Plasma (and Kickoff therefore) does prefer to use the SVG icons from the desktop theme currently, and only falls back to the icon theme if they do not exist. And this results in a mixture of styles now. But whatever. This is out of scope of this bug report anyway. The missing plasma-nm icons are there now, thank you very much again for adding them. I think i will remove the history icon from the theme and see how it looks in the icon theme proper, not sure how history was, maybe it is that ugly Hourglass icon that i should have remade long time ago It's a page with an hourglass on it at the moment. That makes sense, since it's basically "recently accessed documents". For plasma-nm, though, wouldn't the proper icon be the green refresh circle-arrow? That what I'd expect to see, since rescanning networks means refreshing the network list (and one of the reasons why I'm using Air/Oxygen is for colourful icons, it's faster to locate them when they stand out). Dainius Masiliūnas yes and i agree the green icon looks better there, maybe the best thing is kist to remove the plasma svg file with those 2 icons and see if it looks better with standard oxygen icons... Its a dangerous area because air was supposed to have monochromatic simplistic icons opposed to the oxygen colourful ones, (mostly to avoid distractions) and were to be used like that but one does not control it all and things end up messy and oxygen colourful icons ended up in the plasma theme, and I'm trying to avoid doing that sort of thing. so if i could just remove the svg file and know what sort of icon name will the nm look for and kickoff as well I could make those in oxygen proper... and see if nothing else gets broken.. (In reply to pinheiro from comment #48) > Dainius Masiliūnas yes and i agree the green icon looks better there, maybe > the best thing is kist to remove the plasma svg file with those 2 icons and > see if it looks better with standard oxygen icons... If you remove the file view.svgz completely, Plasma will use the one from the Breeze desktop theme instead, i.e. will use the Breeze icons in those cases. See comment#12 for Plasma's behavior in my experience. Can't you just put back the "view-history" icon from the previous git version? And the green icon (for "view-refresh") apparently is not in the Oxygen icon theme (at least not with the proper name), otherwise it would have been used before. Strange enough, I do see it in openSUSE's oxygen5-icon-theme package though... Created attachment 102617 [details]
Screenshot with the new icons
It looks like the patch has landed in Tumbleweed now, but... somehow, I still can't see the aeroplane icon? See the attachment...
(In reply to Dainius Masiliūnas from comment #50) > Created attachment 102617 [details] > Screenshot with the new icons > > It looks like the patch has landed in Tumbleweed now, > still can't see the aeroplane icon? See the attachment... Try to delete Plasma's theme caches, i.e. the files plasma* in ~/.cache/ (and logout/login). It seems that the theme version has not been updated, so Plasma isn't aware that there might be changes. (In reply to Wolfgang Bauer from comment #51) > Try to delete Plasma's theme caches, i.e. the files plasma* in ~/.cache/ > (and logout/login). > It seems that the theme version has not been updated, so Plasma isn't aware > that there might be changes. I did that, but it didn't help. Curious. (In reply to Dainius Masiliūnas from comment #52) > I did that, but it didn't help. Curious. It should, if you delete ~/.cache/plasma_theme_air_v1.1.kcache in particular. Maybe try to do it when Plasma is not running, i.e. login to a different desktop session or quit plasmashell first with "kquitapp5 plasmashell" (you can restart it afterwards by running "plasmashell" in Konsole or the Alt+F2 KRunner dialog). And/or try a fresh user account as a test. |
