| Summary: | Window highlight of minimized windows creates clipping with windows's shadow | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Alexandre Pereira <pereira.alex> |
| Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Flags: | mgraesslin:
ReviewRequest+
|
| Priority: | NOR | ||
| Version First Reported In: | 5.7.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D2748 | ||
| Latest Commit: | http://commits.kde.org/kwin/d910217bb97402b9fd3bf29ff5753fc3579cd38b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Alexandre Pereira
2016-09-09 13:33:29 UTC
Sorry, in the description, the image URL is : http://imgur.com/a/CX6wM https://github.com/psifidotos/nowdock-plasmoid/issues/28 is the url where I reported it to nowdock Thanks Looks like an incorrect repaint in highlight windows. Should be fairly simple to fix. Interesting with "normal" task bar I am not able to reproduce the issue. and NowDock I cannot test because it fails with Plasma 5.8 (no screen property) urgh I found the problem: effects->addRepaint(w->geometry().adjusted(-16,-16,16,32)); // add some padding. w->addRepaintFull() is wrong for at least isInitiallyHidden ... With a large shadow that's just going to break, changing decoration to reproduce. So far I didn't find any window decoration which breaks. Could you please tell me which decoration you used in that screenshot? Its breeze decoration but with shadow size of 65px and strength 75%.
I am able to use nowdock in master when i comment that line in main.qml:
--- a/contents/ui/main.qml
+++ b/contents/ui/main.qml
@@ -168,7 +168,7 @@ Item {
id: tasksModel
virtualDesktop: virtualDesktopInfo.currentDesktop
- screen: plasmoid.screen
+ // screen: plasmoid.screen
activity: activityInfo.currentActivity
filterByVirtualDesktop: plasmoid.configuration.showOnlyCurrentDesktop
Tested with normal taskmanager: it also breaks on master, if on panel. If its a single plasmoid on the desktop, it doesn't break. its shadow size of 64px, sorry. uploading video to show See video: https://youtu.be/moSbI5KsVM0 (In reply to Alexandre Pereira from comment #9) > its shadow size of 64px, sorry Thanks, with these settings I'm able to reproduce Thanks ! Git commit d910217bb97402b9fd3bf29ff5753fc3579cd38b by Martin Gräßlin. Committed on 14/09/2016 at 08:44. Pushed by graesslin into branch 'master'. [effects] Repaint expandedGeometry in HighlightWindowsEffect Summary: The highlight windows effect tried to trigger repaints with the shadow included by having an hardcoded pixel offset. This of course breaks if the shadow is larger than the hardcoded value. The reason presented on why it was done like that is no longer true and in the effects the actual visible area including decorations and shadows is available through the expandedGeometry. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2748 M +2 -2 effects/highlightwindow/highlightwindow.cpp http://commits.kde.org/kwin/d910217bb97402b9fd3bf29ff5753fc3579cd38b |