Bug 368491

Summary:	git master:2016-09-09: Proxies used for final render!
Product:	[Applications] kdenlive	Reporter:	Evert Vorster <evorster>
Component:	User Interface	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/kdenlive/b00844ae8a3f779dd298c63e9d7a0cacceb4385e	Version Fixed In:
Attachments:	Test Project with the issue Rendered output

Description Evert Vorster 2016-09-09 12:40:21 UTC

My proxy settings are very low resolution. 
Once I was happy that my project was done, I rendered out, making sure that rescaling is turned off, and that my project parameters were set to the desired output resolution. 
There used to be a "render using proxy clips" but I can't find a button for it. 

My output quality was terrible until I disabled proxies for the project, after which the output quality was returned to what I am used to.

Reproducible: Always

Steps to Reproduce:
1.Enable Proxies on project
2.Set Proxy resolution to very low so that the quality drop is apparent
3.Put clip on timeline
4.Render
5.Play back the rendered video

Actual Results:  
The output has been rendered using the proxy clips

Expected Results:  
The output must be rendered using the original clips

Comment 1 Evert Vorster 2016-09-09 14:15:08 UTC

It seems I missed a step to reproduce the issue. 

After dropping the file on the timeline, save the project, and restore the saved file, or just hit "revert"

I would guess it's the way that the proxies are handled in the save file?

Comment 2 Jean-Baptiste Mardelle 2016-09-10 21:31:37 UTC

The "Render with proxy clip" option is still here in the "More options" of the render widget. Can you make sure it is not checked ? I cannot reproduce your problem, could you attach a simple project file that has this problem for you?

Comment 3 Evert Vorster 2016-09-10 21:35:47 UTC

I found the box, and it is NOT ticked. It is also not something I would tick. 

I am now making a test project for you to test.

Comment 4 Evert Vorster 2016-09-10 21:38:22 UTC

Created attachment 101022 [details]
Test Project with the issue

Comment 5 Jean-Baptiste Mardelle 2016-09-10 21:45:58 UTC

Ok, I now understand the problem, thanks. Working on it.

Comment 6 Evert Vorster 2016-09-10 21:53:01 UTC

Created attachment 101023 [details]
Rendered output

This is a short render, showing just what the output looks like. 
When I disable proxies for the project I get beautiful FullHD. 

"Render using Proxies" is Un-ticked
Video quality is 25, and encoder speed is slower. 

I'm not sure if it matters, but the project's framerate differs from the clip. 

-Evert-

Comment 7 Jean-Baptiste Mardelle 2016-09-10 22:10:46 UTC

Git commit b00844ae8a3f779dd298c63e9d7a0cacceb4385e by Jean-Baptiste Mardelle.
Committed on 10/09/2016 at 22:10.
Pushed by mardelle into branch 'Applications/16.08'.

FIx proxy used for rendering when app started from home dir

M  +4    -4    src/mainwindow.cpp
M  +8    -1    src/mltcontroller/bincontroller.cpp

http://commits.kde.org/kdenlive/b00844ae8a3f779dd298c63e9d7a0cacceb4385e