Bug 368423

Summary: After back from "Review patch" document gets title "Overview" instead of file name, and document becomes "Read only"
Product: [Developer tools] kdevplatform Reporter: Piotr Mierzwinski <piotr.mierzwinski>
Component: patchreviewAssignee: kdevelop-bugs-null
Status: RESOLVED WORKSFORME    
Severity: normal CC: david.narvaez, david.nolden.kde
Priority: NOR    
Version First Reported In: 5.0.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Piotr Mierzwinski 2016-09-07 20:40:00 UTC 
As in title "Review patch" option makes that after back to "Code" context document lose title on tab and becomes read only. Refresh doesn't help. There is need to close and open file again.

Reproducible: Always

Steps to Reproduce:
1. Open KDevelop with some (versioned) project (I use git).
2. Open some document
3. Make some changes, save file
4. Use "Git -> Show differences"
5. Back from "Review" using "Finish review"
6. Clicking RMB in document should be visible "Patch review" option - click into it
7. In this view click "Update" and "Finish review"
8. Being in "Code" context check title of changed document and try modify it

Actual Results:  
Title on tab gets name "Overview" instead of actual file name and this document becomes read only.

Expected Results:  
Title on tab should has the same name as original file. Should be possible to edit this document.

KF-5.25, Qt-5.7.0
Packages built from git (at 2016/09/05), branch 5.0.
kdevelop-git-debug-5.0.0.r23429.f5cf3c6
kdevplatform-git-debug-5.0.0.r13375.d5aa9f3
Comment 1 David E. Narvaez 2017-10-07 16:01:20 UTC 
I cannot reproduce in KDevelop version 5.1.2 (I have other problems related to the patch review UI but not this). If you can still reproduce this please reopen the bug.