Bug 368245

Summary: "disable timeline effects" only disables timeline clip effects, but not bin clip and track effects
Product: [Applications] kdenlive Reporter: Wegwerf <wegwerf-1-2-3>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal CC: snd.noise
Priority: NOR    
Version First Reported In: 16.08.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/kdenlive/670d54393d1d504032848553b82f4122353f3c9f Version Fixed In:
Sentry Crash Report:

Description Wegwerf 2016-09-04 19:05:16 UTC 
I'm not sure if this is a bug at all, so close if this is not a bug. While writing some posts for kdenlive.org I found out that timeline > disable timeline effects" does not disable all effects in the timeline. In fact:
+ it does disable timeline clip effects,
- it doesn't disable track effects,
- and it doesn't disable bin clip effects.
What would be the expected behavior? +-- or +++? ;)

Reproducible: Always
Comment 1 Jean-Baptiste Mardelle 2016-09-04 19:49:38 UTC 
I would vote for ++- :)
There is an option somewhere to disable bin effects. The basic idea in my mind was that bin effects would mostly be used for color correction which is quite intense and should be easily disabled separately.
I agree that track effects should be affected when disabling timeline effects, will look at it..
Comment 2 Wegwerf 2016-09-04 20:01:04 UTC 
Whatever you deem sensible. Not least according to wording ++- makes most sense, as the timeline consists of tracks and clips. Argh, I'm now blinded by the obvious...!

I will happily update the toolkit posts to reflect the situation. Thank you for reminding me that there's also the disable bin effect option.
Comment 3 farid 2016-10-05 03:13:05 UTC 
Hi Wegwerf, is this issue resolved?
Comment 4 Wegwerf 2016-10-05 05:47:32 UTC 
Not completely. The previous state isn't remembered as is for the effects stack, so this reenables all effects. For this reason I left it open.
Comment 5 Jean-Baptiste Mardelle 2016-10-08 13:59:33 UTC 
Git commit 670d54393d1d504032848553b82f4122353f3c9f by Jean-Baptiste Mardelle.
Committed on 08/10/2016 at 13:59.
Pushed by mardelle into branch 'master'.

Remember track effect state when disabling timeline effects

M  +14   -4    src/timeline/effectmanager.cpp
M  +1    -1    src/timeline/effectmanager.h
M  +3    -4    src/timeline/track.cpp
M  +1    -1    src/timeline/track.h

http://commits.kde.org/kdenlive/670d54393d1d504032848553b82f4122353f3c9f
Comment 6 Wegwerf 2016-10-08 14:49:21 UTC 
Great! Thank you very much, Jean-Baptiste!! This makes my workflow much better, as it preserves the state I'm working on while I can quickly switch off all effects for checking the cutting sequence.