| Summary: | Change in sorting mode only has effect after Dolphin to be restarted | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Patrick Silva <bugseforuns> |
| Component: | view-engine: general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | apmichalopoulos, christophe, JasonW94, jtamate, meven, nate |
| Priority: | NOR | ||
| Version First Reported In: | 23.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/c7dd75500a1796c1d938be4d9c0ad089476b3951 | Version Fixed/Implemented In: | 25.12 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2016-09-01 20:11:01 UTC
Confirmed. There is no need to restart. It is enough to close and open again the settings dialog. But the bug is still valid.
For developers:
According to GammaRay, dolphin has two objects GeneralSettings (but it should be a singleton!), one created in:
return QUrl::fromUserInput(GeneralSettings::homeUrl(), QString(), QUrl::AssumeLocalFile); in dolphin/src/global.cpp (47)
and the other created in:
mainWindow->openDirectories(urls, splitView); in dolphin/src/main.cpp (151)
...
loadSortingSettings(); in src/kitemviews/kfileitemmodel.cpp (60)
*** Bug 407078 has been marked as a duplicate of this bug. *** it's still reproducible with Dolphin 19.08 RC on Arch Linux. 1. open Dolphin 2. press ctrl+shift+, to open Dolphin preferences 3.. change "Sorting mode" in "General" section 4. click 'OK" button Actual Results: Previous sorting mode is still working until Dolphin is restarted Expected Results: New sorting mode works immediately Operating System: Arch Linux KDE Plasma Version: 5.16.4 KDE Frameworks Version: 5.60.0 Qt Version: 5.13.0 Looking into this, and it seems like the issue is that the GeneralSettings object is not emitting the sortingChoiceChanged signal when the sorting choice is actually changed. It does emit the sortingChoiceChanged signal when the dialog is opened, which is why reopening the settings dialog applies the sorting. This is connected to the KFileItemModel slot slotSortingChoiceChanged. The GeneralSettings class is generated by the dolphin_generalsettings.kcfg file, so it seems weird that it isn't emitting signals correctly. That should be automatic? Jamie Torres's comment above suggests that there are two instances of the GeneralSettings singleton, so perhaps they're both emitting the signal at different times, and the one that is emitting it when the dialog is opened but not when the setting is changed is the one that is being connected to the KFileItemModel? *** Bug 420555 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/1072 Git commit c7dd75500a1796c1d938be4d9c0ad089476b3951 by Méven Car. Committed on 23/10/2025 at 13:46. Pushed by meven into branch 'master'. CMakeLists.txt: make sure settings.kcfg are shared Between all dolphinprivate library users. So that the KConfigSkeleton singleton have unique instances accross libraries bounds. To fully fix the bug, make sure to save the modified file to disk. M +0 -26 src/CMakeLists.txt M +2 -0 src/settings/dolphin_compactmodesettings.kcfgc M +2 -0 src/settings/dolphin_contentdisplaysettings.kcfgc M +2 -0 src/settings/dolphin_contextmenusettings.kcfgc M +2 -0 src/settings/dolphin_detailsmodesettings.kcfgc M +2 -1 src/settings/dolphin_directoryviewpropertysettings.kcfgc M +3 -0 src/settings/dolphin_generalsettings.kcfgc M +2 -0 src/settings/dolphin_iconsmodesettings.kcfgc M +2 -0 src/settings/dolphin_versioncontrolsettings.kcfgc M +2 -0 src/settings/viewmodes/contentdisplaytab.cpp https://invent.kde.org/system/dolphin/-/commit/c7dd75500a1796c1d938be4d9c0ad089476b3951 |