Bug 367918

Summary:	The width of the panel is not respected
Product:	[Plasma] plasmashell	Reporter:	Lucas <kdeokk>
Component:	Global Theme packages	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	major	CC:	kde, plasma-bugs
Priority:	NOR
Version:	master
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-workspace/aea33cddb547cc2ba98be5dd45dc7562b32b4b9a	Version Fixed In:

Description Lucas 2016-08-28 12:18:54 UTC

The width of the panel is not respected

Reproducible: Always

Steps to Reproduce:
1. Create a new look and feel package using Plasma lf explorer, lets call it test.
2. Change the panel width
3. Save the changes using option "Layout from current plasma setup"
4. Open system settings> look and feel, check "use desktop layout from theme" and switch to a new lf "test"package. 
5. The width of the panel does not change.


Actual Results:  
The width of the panel does not change

Expected Results:  
The width of the panel should change

Other changes like panel placement (top, bottom etc) and widget settings are respected.

Comment 1 David Edmundson 2016-08-28 19:40:02 UTC

>2. Change the panel width

How?

Comment 2 Lucas 2016-08-28 22:21:20 UTC

Hmm by using sliders on the panel like this http://wstaw.org/w/46Lv/

Comment 3 Lucas 2016-08-30 18:44:09 UTC

Video showing the issue

Comment 4 Lucas 2016-08-30 18:45:19 UTC

https://youtu.be/3uZnBzoU7nk

Comment 5 David Edmundson 2016-08-31 12:45:18 UTC

Yeah it's stupidly coded. Will see if we can fix it.

Comment 6 Marco Martin 2016-10-11 14:45:54 UTC

Git commit aea33cddb547cc2ba98be5dd45dc7562b32b4b9a by Marco Martin.
Committed on 11/10/2016 at 14:45.
Pushed by mart into branch 'Plasma/5.8'.

restore all panel properties

Summary:
restore the missing panel properties:
alignment
minimum length
maximum length
offset

also, allow non integer values for the measures (height, min/max, offset)
Related: bug 368074

Test Plan:
dumped a config with a custom panel, different height/alignment/offset etc
started a new plasma session with that l&f package, restored panel correctly

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3021

M  +5    -1    shell/scripting/scriptengine_v1.cpp
M  +14   -7    shell/shellcorona.cpp

http://commits.kde.org/plasma-workspace/aea33cddb547cc2ba98be5dd45dc7562b32b4b9a