Bug 367829

Summary:	"Open terminal here" will always open at $HOME
Product:	[Applications] krusader	Reporter:	Olivier <g1325937>
Component:	general	Assignee:	Krusader Bugs Distribution List <krusader-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alex.bikadorov, clearmartin, krusader-bugs-null, nikita+kde
Priority:	NOR
Version First Reported In:	Git
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Olivier 2016-08-26 04:30:47 UTC

Since the upgrade to Qt5 opening a terminal will always open it at $HOME, regardless of configuration.
I used to have "konsole  --new-tab --workdir %d" before the upgrade, but now it just won't work. Setting "default terminal" to "echo konsole  --new-tab --workdir %d" will just print "konsole  --new-tab --workdir %d", which probably means there's no substitution going on like with commands? Setting it to just "konsole" will have the same result (obviously without opening a new tab).

Reproducible: Always

Steps to Reproduce:
1. Press F9 (or set shortcut for "open terminal here", F11 in my case) or click "Term" button

Actual Results:  
It will open terminal at $HOME

Expected Results:  
It should open on current folder.

My system is Ubuntu 16.04 64b, built from git against KDE Frameworks 5.23.0, Qt 5.5.1. If any other information is required, I'll provide it.

Comment 1 Martin Kostolný 2016-08-26 04:39:21 UTC

Hi! Thanks for report. Can you please try setting "konsole --nofork"? This is the default value for Krusader now.

Comment 2 Olivier 2016-08-26 05:01:05 UTC

"konsole --nofork --new-tab" actually did the trick! Thank you very much Martin.
I actually didn't think of checking out the new defaults after migrating from the older qt4 version. My bad entirely!

Comment 3 Olivier 2016-08-26 05:07:14 UTC

Oh, wait, actually, it doesn't open a new tab. Is there anything that can be done about that?

Comment 4 Martin Kostolný 2016-08-26 07:08:44 UTC

Not from Krusader side. If I try to run "konsole --new-tab" from krunner (alt+f2), it still opens a new konsole window therefore I believe it is a konsole problem, but I could be wrong. I've found this: https://bugs.kde.org/show_bug.cgi?id=341672#c1

Maybe it would be worth filing a dedicated bug report on konsole if it turns out there is no way for konsole reusing the same process to create a new tab.

Comment 5 Olivier 2016-08-26 09:58:51 UTC

However konsole --new-tab from anywhere else does open a tab for me. (konsole 15.12.3). I am trying from kupfer (a krunner-like launcher), krusader's command line, other terminals and khotkey as well.

In previous versions of Krusader %d was expanded to the pwd, so I could force it to work on a specific folder via the command I described above, but that doesn't seem to be the case anymore.

Comment 6 Martin Kostolný 2016-09-23 22:18:38 UTC

You are right. Please try the latest git. Populating of %d should now be implemented.

Comment 7 Alex Bikadorov 2016-10-23 10:51:37 UTC

Please test with latest version (2.5.0).

Comment 8 Nikita Melnichenko 2018-05-22 21:38:44 UTC

Closing due to the lack of response.