Bug 367809

Summary: Date label not centered vertically
Product: [Plasma] plasmashell Reporter: Heiko Becker <heiko.becker>
Component: Digital Clock widgetAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: kde, monsoon.cl, nate, simonandric5
Priority: NOR    
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Exherbo   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: before screenshot
after screenshot
new screenshot
Digital clock not centered vertically
Digital clock not centered vertically

Description Heiko Becker 2016-08-25 17:32:26 UTC
Created attachment 100754 [details]
before screenshot

With the latest master the digital clock almost overlaps the panel when "Show date" is enabled. Or at least it's glued to the border of the panel. As a consequence it's isn't centered vertically.

I've attached two screenshots, one of 5.7.4 and one of current master.

The commit which introduced this seems to be 9016eaae22db317811f5fdae29bdeba594cf6310 "Don't set both font and pixel size in DigitalClock". When I revert it the clock looks the same as with 5.7.4.

Qt version is 5.7.0 in both cases.
Comment 1 Heiko Becker 2016-08-25 17:32:54 UTC
Created attachment 100755 [details]
after screenshot
Comment 2 David Edmundson 2016-08-28 00:17:51 UTC
thanks
Comment 3 David Edmundson 2016-09-11 23:42:03 UTC
This is fixed now right?
Comment 4 Heiko Becker 2016-09-12 19:05:17 UTC
(In reply to David Edmundson from comment #3)
> This is fixed now right?

It doesn't overlap anymore, it still isn't centered vertically though.
Comment 5 David Edmundson 2016-09-13 10:38:49 UTC
Can I see a new screenshot please, mine looks fine.
Comment 6 Heiko Becker 2016-09-14 12:29:05 UTC
Created attachment 101080 [details]
new screenshot

Admittedly it's only a tiny bit too far down.
Comment 7 monsoon.cl 2019-04-03 09:34:36 UTC
Fedora 29, KDE Plasma Version 5.14.5

Date label is not centered vertically in my KDE too. (The top padding is 4/2 pixel larger than bottom padding for date/"PM" in my screenshot.)
Comment 8 monsoon.cl 2019-04-03 09:36:41 UTC
Created attachment 119222 [details]
Digital clock not centered vertically
Comment 9 monsoon.cl 2019-04-03 09:36:51 UTC
Created attachment 119223 [details]
Digital clock not centered vertically
Comment 10 Nate Graham 2020-10-18 14:40:41 UTC
Is this still a problem for you in Plasma 5.20? It's looking good for me now.
Comment 11 Heiko Becker 2020-10-18 15:40:21 UTC
It indeed looks fine for me since quite a few versions.