Summary: | Improve Search highlighting Scroll-bar Minimap | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Richard Llom <richard.llom> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED WORKSFORME | ||
Severity: | wishlist | CC: | cullmann, kare.sars, nate |
Priority: | NOR | Keywords: | usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Screenshot |
Description
Richard Llom
2016-08-23 11:12:57 UTC
Created attachment 100725 [details]
Screenshot
Thanks for the report. 1) Yes black is not the optimal color. Yellow is not so good on light themes. The color should probably be configurable/use a theme color. 2) Marking only the match is not an option. If you want that you can turn off the scrollbar marks and get the yellow from the mini-map highlight colors. In large documents you would not be able to distinguish the results as they are merged with the surrounding text. (In reply to Kåre Särs from comment #2) > Thanks for the report. > YW! > 1) Yes black is not the optimal color. Yellow is not so good on light > themes. The color should probably be configurable/use a theme color. > I would advise against yet another option. Also sane defaults are needed anyway (to quote the VDG). If the color is good for the text view, why isn't it sufficient for the minimap? > 2) Marking only the match is not an option. If you want that you can turn > off the scrollbar marks and get the yellow from the mini-map highlight > colors. In large documents you would not be able to distinguish the results > as they are merged with the surrounding text. I can't follow your advice, can you explain it in more detail? If I turn scrollbar marks off, I don't see any marks at all on the scrollbar. Can the minimap algorithm be tuned so that the match doesn't vanish? If still using the weird boxes, please place them at least behind (as background) on the minimap. 1) There is already options for "Marker Colors" but the search match marker is missing (Fonts&Colors -> Colors -> Marker Colors). 2) I meant that you can experiment with removing the "Show scrollbar marks" and see what it looks like when the matches are highlighted and not the whole line. The mini-map already shows the highlighted text, but it is not visible enough. You will quickly notice that in large documents you do not see the matches any more, as the colors are mixed with the surrounding. I think the current state is ok, if one wants further improvements, please provide a patch: https://kate-editor.org/join-us/ |