Bug 367693

Summary: git master - Preview render problem: isn't always rendering timeline properly (video example included)
Product: [Applications] kdenlive Reporter: Unknown <null>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED WORKSFORME    
Severity: normal CC: fritzibaby, julius.kuenzel, kde-bugs, null, wegwerf-1-2-3
Priority: NOR Flags: fritzibaby: timeline_corruption+
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
URL: https://youtu.be/Vmtd9nEYhnI
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Unknown 2016-08-22 20:37:33 UTC
See video link in URL field for details.

Sometimes, when a preview-render has finished for zones in the timeline, making changes within those zones and preview-rendering again doesn't always show updated changes; instead, it reverts back to the cached data (I believe). Deleting the cached data will force it to re-render the zones, which it then works fine.

Reproducible: Always

Steps to Reproduce:
1. Create a new project
2. Add some clips to the timeline, add fx/transitions/titles/whatever
3. Set a preview render zone and start preview render
4. When preview render is done, make changes to clips in that preview render zone and start preview render again.

Actual Results:  
Preview render finishes almost immediately, but uses the already rendered cache data for the timeline and doesn't seem to re-render the areas that have had changes to them since last preview render.

Expected Results:  
Starting preview render will always re-render areas/zones that have had changes to them since last preview-render.

Bug discovered while using Kdenlive 16.11.70 git master build via ppa:kdenlive/kdenlive-master.

Ubuntu 16.04 x64, Unity 7.4.0 desktop environment.

KDE Frameworks 5.18.0.
Qt 5.5.1
Comment 1 Wegwerf 2016-08-23 08:53:06 UTC
Jesse, are you seeing green parts turning red properly, or is this already missing?

I'm seeing incorrect invalidation when using the spacer tool; I've reported so separately.
Comment 2 Unknown 2016-08-23 17:19:12 UTC
Wegerf, lemme do some testing today and I'll reply with whether I experience the error your describing on the latest git master build from the kdenlive-master ppa.
Comment 3 Unknown 2016-08-23 18:12:11 UTC
Wegwerf, I can confirm that the green/red preview render bar is not updating properly when I make changes to (a) the properties of FX on a clip in the timeline, or (b) the location of a clip in the timeline. Changing these doesn't always cause the Preview Render to reflect that changes have been made and a new cache needs to be rendered.
Comment 4 Jean-Baptiste Mardelle 2016-08-24 06:02:53 UTC
Git commit 1df50d2be1311e91611a3ffe829d79b08efff700 by Jean-Baptiste Mardelle.
Committed on 24/08/2016 at 05:51.
Pushed by mardelle into branch 'Applications/16.08'.

Fix timeline preview invalidate when hiding a track

M  +8    -1    src/timeline/timeline.cpp

http://commits.kde.org/kdenlive/1df50d2be1311e91611a3ffe829d79b08efff700
Comment 5 Unknown 2016-08-24 20:12:08 UTC
Looks like the preview render feature is working better now in the case when the user mutes the video on a track, but there are still issues with its behavior when making changes to a clip's effects in the timeline or its position in the timeline.

See updated video example: https://youtu.be/0koc_NKni54
Comment 6 Jean-Baptiste Mardelle 2016-08-25 05:41:21 UTC
Git commit 1d98d4f4c2eed6ed1161101e52aea035b45d71de by Jean-Baptiste Mardelle.
Committed on 25/08/2016 at 05:40.
Pushed by mardelle into branch 'Applications/16.08'.

Fix typo causing failed timeline preview on some fps

M  +1    -1    src/doc/kdenlivedoc.cpp

http://commits.kde.org/kdenlive/1d98d4f4c2eed6ed1161101e52aea035b45d71de
Comment 7 Unknown 2016-08-25 17:34:50 UTC
Fixed, works PERFECTLY! You're the man. Thanks JB!
Comment 8 Unknown 2017-05-01 22:21:45 UTC
I need to re-open this bug. Looks like it's occurring, again, in 17.07.70 master ppa build. Same issue happens on a project in 1080p, 30fps: changing a clip's position in Timeline, even Adding a clip to a new track over clips that have been preview-rendered and starting preview render DOESN'T actually build a new preview render. Anything that was red (un-rendered) immediately switched to green (rendered), but doesn't reflect the changes I've made in the timeline.
Comment 9 Julius Künzel 2021-04-01 20:03:00 UTC
Can you please update to the latest version (20.12.3 at the moment, https://kdenlive.org/en/download/) and report here whether this is still happening?
Comment 10 Bug Janitor Service 2021-04-16 04:33:17 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Bug Janitor Service 2021-05-01 04:33:37 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!