Bug 367672

Summary: removed --nofork option with apps 16.08.0
Product: [Applications] konsole Reporter: Luca Giambonini <luca86>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal CC: christian.bay91, wbauer1
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Chakra   
OS: Linux   
Latest Commit: https://cgit.kde.org/konsole.git/commit/?id=c6ffcaff557760f46ba5813823868e656b45da0f Version Fixed In: 16.12.1
Sentry Crash Report:

Description Luca Giambonini 2016-08-22 13:15:20 UTC 
With this commit the option --nofork was removed. Nor in the announcement nor in the full apps 16.08.0 log this change is mentioned.

https://quickgit.kde.org/?p=konsole.git&a=blobdiff&h=129a5cf0bc66ee4ddc7e30c1c5a2c94246277b3f&hp=5e1420e37363454cf5e7886a82381cb9eb4447d8&hb=27dec8d02f705c77eef45a2533bed203eec9454f&f=src%2Fmain.cpp

the removal is desired? or it occurred by mistake?

Reproducible: Always
Comment 1 Luca Giambonini 2016-08-22 17:34:55 UTC 
I will add an example, this was a working line before the update of 16.08.0:
konsole --nofork -e bash -c /tmp/.qt_temp_1508913749

where the .qt_temp_* file contains the instruction to be executed in the konsole.
Comment 2 Wolfgang Bauer 2016-08-23 21:11:52 UTC 
Konsole never had a -c option AFAICT.

In your example, -c is actually an option for bash.

Konsole 16.08 (using QCommandLineParser) incorrectly treats it as an (unknown) option for konsole now though, instead of ignoring the arguments after -e and passing them to the command that is to be run (bash).

See bug#366793.

--nofork has indeed been "removed" in 16.08.
I have no idea whether this is on purpose or by mistake, nor whether --nofork even still makes sense with KF5/Qt5.
What I can say though is that this is also related to the switch to QCommandLineParser. The --nofork option was not konsole specific, but provided by kdelibs4's KCmdLineArgs.
Comment 3 christian.bay91 2016-11-01 10:48:07 UTC 
I can confirm the removal. Really annoys me because I used this option
every time I start an external editor in kmail.
Comment 4 Wolfgang Bauer 2016-12-20 10:19:36 UTC 
Actually the --nofork option has been added to konsole yesterday:
https://cgit.kde.org/konsole.git/commit/?id=c6ffcaff557760f46ba5813823868e656b45da0f

So I think we can close this as fixed.