Bug 367512

Summary:	Filters get applied while adjustment and the preview gets stuck due to this. This action is sometimes not undoable
Product:	[Applications] krita	Reporter:	Raghavendra kamath <raghu>
Component:	Filters	Assignee:	Halla Rempt <halla>
Status:	RESOLVED FIXED
Severity:	major	CC:	halla
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/krita/80f83924db6f8d543b54959b7f885e69f3dc783e	Version Fixed/Implemented In:
Sentry Crash Report:

Description Raghavendra kamath 2016-08-18 14:59:45 UTC

Filters get applied while adjustment and the preview gets stuck due to this. This action is sometimes not undoable. Clicking cancel in the filter dialog has no effect as the filter is already applied while calculating the preview. 

Even ctrl + z doesn't bring back the original image sometimes, then closing document without saving and reopening it is only choice.

Reproducible: Always

Steps to Reproduce:
1. Open any image in krita
2.trigger any filter like hue saturation or Gaussian blur and adjust the sliders
3.you'll notice the filter gets stuck at some point, while the layer panel shows progress of filter application
4. cancel the dialog and you'll notice that it doesn't cancel the filter

I asked on IRC and it seems this is only on linux as scottyp couldn't reproduce it in windows.
Quiralta on IRC confirmed that this happens to him too. both of us have arch linux machines. so we need to check on other distros too.

I am marking this major as filters are a bit unusable in this condition

Comment 1 Raghavendra kamath 2016-08-18 17:00:39 UTC

I think after this -> https://quickgit.kde.org/?p=krita.git&a=commit&h=ebc8a43ce07b6152abfb2fb88509c4bad1439f46 commit the filter started to behave this way

Comment 2 Halla Rempt 2016-08-19 06:58:35 UTC

i'll look into it over the weekend.

Comment 3 Halla Rempt 2016-08-20 08:55:13 UTC

Git commit 80f83924db6f8d543b54959b7f885e69f3dc783e by Boudewijn Rempt.
Committed on 20/08/2016 at 08:54.
Pushed by rempt into branch 'master'.

M  +5    -2    libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp

http://commits.kde.org/krita/80f83924db6f8d543b54959b7f885e69f3dc783e