Bug 367120

Summary: Neon download link shouldn't use a form tag
Product: [Websites] www.kde.org Reporter: KDE Neon user <emailmeat>
Component: generalAssignee: kde-www mailing-list <kde-www>
Status: RESOLVED FIXED    
Severity: major CC: jr
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
URL: https://neon.kde.org/download
Latest Commit: http://commits.kde.org/websites/neon-kde-org/096894d6d83c81419585489a40fa643588c6ceb0 Version Fixed In:

Description KDE Neon user 2016-08-17 13:56:23 UTC 
https://neon.kde.org/download (a secure page) uses a form HTML tag to redirect the user to the download page instead of a normal link. That's bad practice for many reasons, including that the download page is non-secure (http:),  which makes browsers like Firefox throw a security warning, and that it breaks the expected user experience, like right-clicking on the link to open it in a new tab.

Reproducible: Always
Comment 1 Albert Astals Cid 2016-08-17 21:15:22 UTC 
Jonathan please get this fixed
Comment 2 Jonathan Riddell 2016-08-18 10:33:49 UTC 
Git commit 096894d6d83c81419585489a40fa643588c6ceb0 by Jonathan Riddell.
Committed on 18/08/2016 at 10:33.
Pushed by jriddell into branch 'master'.

use normal <a> link instead of <button> for download links

D  +0    -77   download-test.php
M  +9    -9    download.php

http://commits.kde.org/websites/neon-kde-org/096894d6d83c81419585489a40fa643588c6ceb0