Summary: | Konsole doesn't show crash dialog when it crashes | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Wolfgang Bauer <wbauer1> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/konsole/391828aa2313f06b0ccc3ad2c60bf0661703e236 | Version Fixed In: |
Description
Wolfgang Bauer
2016-08-16 21:19:25 UTC
OK thanks, that's news to me - I didn't realize something had changed that required every app to call that now. Git commit 30fe2a0b9d93617c80f6e3d5a61d845a5fb526ab by Kurt Hindenburg. Committed on 28/08/2016 at 19:05. Pushed by hindenburg into branch 'master'. Add KCrash code so krkonqi crash dialog works again M +1 -1 CMakeLists.txt M +1 -0 src/CMakeLists.txt M +3 -0 src/main.cpp http://commits.kde.org/konsole/30fe2a0b9d93617c80f6e3d5a61d845a5fb526ab (In reply to Kurt Hindenburg from comment #1) > OK thanks, that's news to me - I didn't realize something had changed that > required every app to call that now. kdelibs4support takes care of it, but that's not used any more in konsole 16.08... AFAIK it is not even necessary to call KCrash::initialize() at all, just *linking* to KCrash should enable the crash dialog. But cmake or the linker may optimize that out, so KCrash::initialize() was added in Frameworks 5.15 to be able to make sure KCrash is linked in by calling that. See https://git.reviewboard.kde.org/r/126868/ and the links to the mailinglist discussion mentioned there. Git commit 391828aa2313f06b0ccc3ad2c60bf0661703e236 by Kurt Hindenburg. Committed on 31/08/2016 at 12:37. Pushed by hindenburg into branch 'Applications/16.08'. Add KCrash code so krkonqi crash dialog works again (cherry picked from commit 30fe2a0b9d93617c80f6e3d5a61d845a5fb526ab) M +1 -1 CMakeLists.txt M +1 -0 src/CMakeLists.txt M +3 -0 src/main.cpp http://commits.kde.org/konsole/391828aa2313f06b0ccc3ad2c60bf0661703e236 |