Bug 366769

Summary:	Rename aborts after first rename of many
Product:	[Applications] digikam	Reporter:	Geoff King <gsking1>
Component:	AdvancedRename-engine	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	5.1.0
Target Milestone:	---
Platform:	macOS (DMG)
OS:	macOS
Latest Commit:		Version Fixed In:	5.3.0
Sentry Crash Report:

Description Geoff King 2016-08-15 00:37:15 UTC

Renaming video files fails after the first of many files to be renamed.  This affects my MP4 video files.  It does not affect jpg files. 
This appears similar to bug 357617

Reproducible: Always

Steps to Reproduce:
1.  Select several video files (in my case MP4 from GoPro)
2. F2 to start rename dialog.  
3. Change the name and start the rename.

Actual Results:  
The first file is renamed, but the others are not.  a Renaming Images dialog box comes up and says Please wait... Processing.  The only option is to Abort.  

Expected Results:  
All the files would be renamed. Instead 1 of 10 files were renamed.

This appears similar to bug 357617

Comment 1 Geoff King 2016-08-15 00:45:58 UTC

I just tried it with some MOV files and some of those changed the name two at a time.

Comment 2 caulier.gilles 2016-08-15 05:25:15 UTC

What do you use as rename scheme to complete the operation ?

Gilles Caulier

Comment 3 Maik Qualmann 2016-08-16 06:12:46 UTC

Git commit bb07b39065c7ba8d5b2763097ebdba05baa54a6b by Maik Qualmann.
Committed on 16/08/2016 at 06:10.
Pushed by mqualmann into branch 'master'.

filter out multiple signals from ThumbnailLoadThread
Related: bug 357617
FIXED-IN: 5.2.0

M  +2    -1    NEWS
M  +5    -12   utilities/advancedrename/advancedrenameprocessdialog.cpp

http://commits.kde.org/digikam/bb07b39065c7ba8d5b2763097ebdba05baa54a6b

Comment 4 Maik Qualmann 2016-08-16 19:29:55 UTC

Git commit 24e1d9e0a67ff6179a6dbf26f9a4ca2589ed8445 by Maik Qualmann.
Committed on 16/08/2016 at 19:28.
Pushed by mqualmann into branch 'master'.

fix possible deadlocks from video thumbnailer

M  +7    -7    libs/threadimageio/videothumbnailer.cpp
M  +3    -6    libs/threadimageio/videothumbnailer.h
M  +18   -16   libs/threadimageio/videothumbnailer_p.cpp
M  +1    -0    libs/threadimageio/videothumbnailer_p.h
M  +35   -27   libs/threadimageio/videothumbnailerjob.cpp
M  +2    -5    libs/threadimageio/videothumbnailerjob.h

http://commits.kde.org/digikam/24e1d9e0a67ff6179a6dbf26f9a4ca2589ed8445

Comment 5 Maik Qualmann 2016-08-16 19:39:52 UTC

Gilles,

can you test with the current git/master version on Mac OS X the renaming of mixed video and image files? Video monitoring is not available under Mac OS X. I think there should be no problems more.

Maik

Comment 6 Maik Qualmann 2016-08-16 20:17:54 UTC

Git commit 28939a4dca842c0feaa802ee15e07ba6a5ce52f9 by Maik Qualmann.
Committed on 16/08/2016 at 20:16.
Pushed by mqualmann into branch 'master'.

Revert "fix possible deadlocks from video thumbnailer"

M  +7    -7    libs/threadimageio/videothumbnailer.cpp
M  +6    -3    libs/threadimageio/videothumbnailer.h
M  +16   -18   libs/threadimageio/videothumbnailer_p.cpp
M  +0    -1    libs/threadimageio/videothumbnailer_p.h
M  +27   -35   libs/threadimageio/videothumbnailerjob.cpp
M  +5    -2    libs/threadimageio/videothumbnailerjob.h

http://commits.kde.org/digikam/28939a4dca842c0feaa802ee15e07ba6a5ce52f9

Comment 7 Maik Qualmann 2016-08-17 20:48:38 UTC

Git commit 7745925f7c54bac7dab6b19be67fe5d3b0828c18 by Maik Qualmann.
Committed on 17/08/2016 at 20:47.
Pushed by mqualmann into branch 'master'.

fix possible deadlocks from video thumbnailer #2

M  +7    -2    libs/threadimageio/videothumbnailerjob.cpp

http://commits.kde.org/digikam/7745925f7c54bac7dab6b19be67fe5d3b0828c18

Comment 8 Geoff King 2016-09-22 00:19:03 UTC

Looks to be fixed now on 5.2.0 for Mac.  Thanks and please close.