Bug 366533

Summary:	No icon for clementine in kmix
Product:	[Applications] kmix	Reporter:	Salvo "LtWorf" Tomaselli <tiposchi>
Component:	Visual: Layout and GUI	Assignee:	pinheiro <nuno>
Status:	RESOLVED FIXED
Severity:	minor	CC:	jjm
Priority:	NOR
Version First Reported In:	4.5
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	screenshot

Description Salvo "LtWorf" Tomaselli 2016-08-08 18:25:33 UTC

See attachment.

Clementine does have its own icon and there is a breeze icon.

It could be a kmix bug, please reassign if I'm wrong.

Reproducible: Always

Steps to Reproduce:
1. Try to change the volume of clementine.

Comment 1 Salvo "LtWorf" Tomaselli 2016-08-08 18:25:57 UTC

Created attachment 100498 [details]
screenshot

Comment 2 pinheiro 2016-08-15 10:28:35 UTC

is clementine now a oficial part of KDE? I can do that app icon sure

Comment 3 Salvo "LtWorf" Tomaselli 2016-08-15 17:42:14 UTC

I have no idea of clementine's affiliations. I just know there is such an icon in breeze and breeze-dark

Comment 4 pinheiro 2016-08-15 20:50:52 UTC

The main criteria used to be apps that are part of KDE, and a few other I did for fun, its debatable if we should do app icons for apps outside the KDE space, mostly because its might be a violation of the individual apps "brand" say for Gnome file manager we would do an ugly icon that looked like a banana, in that case the app developers in gnome would think with good reason that we were being rude and going out of our way to make their app look bad in a KDEPLasmaDesktop space.

I'm sure this is not the case with clementine nor will it be, in the cases were I did make an icon for an non KDE app I tried to be respectful of the app core brand values...

having said that there might be a bug in kmix as if there is no icon it should use the one the app ships by itself in I think highcolor folder

Comment 5 Salvo "LtWorf" Tomaselli 2016-08-15 21:20:24 UTC

I reassigned to kmix then.

Comment 6 Jonathan Marten 2021-02-06 21:30:27 UTC

KMix now obtains the application icon, whether it is a "KDE application" or not, by asking for its desktop file via DBus.  There are some fallback icon names for those applications which don't provide a desktop file or icon name, but Clementine provides this information and KMix shows the application icon correctly.

Implemented by commit 793c07f3.