Bug 366521

Summary:	Root directories added to the File Search exclusions vanish from the list after you close the settings window
Product:	[Applications] systemsettings	Reporter:	KDE Neon user <emailmeat>
Component:	kcm_baloo	Assignee:	Pinak Ahuja <pinak.ahuja>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, nepomuk-bugs
Priority:	NOR
Version:	5.10.2
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed In:	5.19.0
Sentry Crash Report:

Description KDE Neon user 2016-08-08 12:03:10 UTC

Root directories (such as /etc) can be added to the list of location exclusions to the File Search, but vanish from the list automatically after you close and reopen the system settings.

Reproducible: Always

Steps to Reproduce:
1. Open the System Settings
2. Open the Search preferences
3. Add /etc to your list of exclusions in the File Search tab
4. Close the System Settings window
5. Reopen the System Settings window

Actual Results:  
/etc and any other root directories you added have now vanished from the list.

Expected Results:  
The directories should stay in the list, or, in case they are excluded by default, they shouldn't even appear in the list of folders users can select to be excluded in first place.

Comment 1 Stefan Brüns 2020-03-24 20:39:51 UTC

Git commit 7498b41a1979b084d05b99a51d3561eeef68e974 by Stefan Brüns.
Committed on 24/03/2020 at 20:39.
Pushed by bruns into branch 'master'.

[Baloo KCM] Complete overhaul of the include/exclude folder list

Summary:
The current "Excluded folders" list in the KCM is quite awkward:

1. It tries to mimic baloos automatic exclusion of external drives,
   but fails doing so and adds almost any external drive even when not
   mounted below an indexable path.

2. Deleting an autogenerated entry actually **adds** it to the included
   folder list, and then hides it.

3. There is no way to show the included folder list, or add any entries
   to it.

Remove the custom "excluded mounts" heuristic from the KCM and retrieve
the additional (not explicitly configured) excluded ones from baloo.

Replace the "excluded list" with a common list for included and excluded
folders, and flag its state. This also makes it easy to add additional
properties later.

Create a new UI delegate for each config list item, allowing to enable
and disable indexing for each entry. Make the "delete" actually always
delete a config entry, and make the control inline. Move the "Add" button
to the *right* bottom of the list (in accordance with UI guidelines) and
add some text to it.

Depends on D28024

Solves the following parts of T9879:
[x] Allow adding of includeFolders in the KCM
[x] Correctly show excludeFolders below explicit (non-$HOME) includeFolders in KCM
Related: bug 417763, bug 417762, bug 417170

Reviewers: #baloo, #vdg, ngraham, mart

Reviewed By: #baloo, #vdg, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28025

M  +119  -113  kcms/baloo/filteredfoldermodel.cpp
M  +18   -12   kcms/baloo/filteredfoldermodel.h
M  +76   -19   kcms/baloo/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/7498b41a1979b084d05b99a51d3561eeef68e974

Comment 2 Nate Graham 2020-08-10 14:06:57 UTC

This is fixed with the current version of the KCM.