Bug 366139

Summary:	Krita crashes when editing images created in older versions of the software
Product:	[Applications] krita	Reporter:	mc3dkid
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	crash	CC:	halla
Priority:	NOR
Version First Reported In:	3.0.1 Alpha
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description mc3dkid 2016-07-26 16:58:53 UTC

It seems that Krita is crashing when attempting to edit images created in pre version 3. I have tried to get it to crash while editing a newly created document but can't seem to be able to do so. This crashing doesn't seem to be caused by the tablet but rather something memory related.

Reproducible: Always

Steps to Reproduce:
1.Paint on or Cut part of the image
2.Krita Crashes



krita.exe caused an Access Violation at location 00007FF82562175E in module msvcrt.dll Writing to location 0000000000000000.

AddrPC           Params
00007FF82562175E 000000000000003E 0000000010F1FDF0 0000000000000000  msvcrt.dll!memcpy
000000006F41C788 0000000000000000 0000000010F1FDF8 0000000000029268  libkritaimage.dll!KisSwappedDataStore::swapOutTileData
000000006F405FDF 0000000000000001 000000000F916ED0 FFFFFFFFFF953040  libkritaimage.dll!KisTileDataStore::trySwapTileData
000000006F65571B 000000000F916F01 0000000000000000 0000000000000000  libkritaimage.dll!KisTileDataSwapper::pass<SoftSwapStrategy>
000000006F41CF41 000000006F7A7080 000000000F9CA9C0 000000000AC606E0  libkritaimage.dll!KisTileDataSwapper::run
0000000000AC050C 000000000372A960 0000000000000000 0000000000000000  Qt5Core.dll!QThread::setTerminationEnabled
00007FF825630B13 000000000AC606E0 000000000AC606E0 0000000000000000  msvcrt.dll!_callthreadstartex
00007FF825630BCD 0000000000000000 0000000000000000 0000000000000000  msvcrt.dll!_threadstartex
00007FF8258B13D2 00007FF8258B13B0 0000000000000000 0000000000000000  KERNEL32.DLL!BaseThreadInitThunk
00007FF825CE03C4 0000000000000000 0000000000000000 0000000000000000  ntdll.dll!RtlUserThreadStart

Comment 1 Halla Rempt 2016-07-26 17:03:41 UTC

Hi, 

I haven't seen that happen, and I test with images made back to the 1.6 days. But those might not have used all features... Could you please attach one image that makes Krita crash reliably? If the images are private, you can share them privately with me (boudewijnrempt@gmail.com)

Comment 2 mc3dkid 2016-07-27 16:16:55 UTC

Okay, so I went in and started playing with Krita's Performance settings. Setting the Swap Undo to 25% of my 4096 Memory Limit seemed to increase stability a ton. I think this was set to 0% by default? Hope this info is helpful.

Comment 3 Halla Rempt 2016-07-28 09:31:57 UTC

Hm... No, swap undo after is 2.00% by default, not zero. And your image is fairly small, actually, so I wouldn't expect it to run out of memory, though the crash clearly is in the swapping code.

Comment 4 Halla Rempt 2016-09-27 09:31:26 UTC

I guess there was a glitch reading the settings somewhere -- I checked the default settings and they are correct.