| Summary: | Icons for Electron apps are too large in the System Tray | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Cyan <thaynj> |
| Component: | System Tray | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | normal | CC: | bugseforuns, dos, i, jacobtey, kde, magiruuvelvet, mike, notmart, now.im.627, syadykin, varlesh, vityas_official, weits, zhanibek.adilbekov |
| Priority: | NOR | ||
| Version: | 5.7.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1350#issuecomment-234810164 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
electron apps tray icons bug
Zoom panel 100% compare |
||
|
Description
Cyan
2016-07-24 23:49:41 UTC
screenshot? Created attachment 100642 [details]
electron apps tray icons bug
Comment on attachment 100642 [details]
electron apps tray icons bug
Same here.
plasmashell 5.7.3
On this screen 3 electron apps. Discord icon is ok, but skype and facebook messenger is broken.
This is reproducible with most Electron apps which place a icon in the system tray ─ not with all (Discord for example works fine). The icons are too big (oversized) most of the times and won't fit in. To be honest, its an visual distration. You can try to delete plasma configuration files ~/.config/ I solved my problems by doing so, using KDE Plasma 5.7.95. Hope it is helpful for you too. Created attachment 101919 [details]
Zoom panel 100%
Now for Plasma use only 22px icons for tray... BUT GTK-apps (chrome/chromium) and Electron-apps (wire, nylas and etc) use over 21px icon size on system tray - it's blurred icons and spoil style. For example, Electron-app (Wire) on plasma tray: - Original icon change with hardcode-tray script for better looking this bug - Original icon size 22px - green square, 16px - red square. - On Plasma panel icon cropped to green square 21px or 20,5px and red square cropped to 14,5px or 15px Please see this post: https://github.com/bil-elmoussaoui/Hardcode-Tray/issues/183 Attached file - see green/red icon have oreol OS: KDE Neon 5.8.2 (In reply to varlesh from comment #7) > Now for Plasma use only 22px icons for tray... BUT GTK-apps > (chrome/chromium) and Electron-apps (wire, nylas and etc) use over 21px icon > size on system tray - it's blurred icons and spoil style. > > For example, Electron-app (Wire) on plasma tray: > - Original icon change with hardcode-tray script for better looking this bug > - Original icon size 22px - green square, 16px - red square. I tried wire, and wile the icon definitely doesn't looks that good (scaled down) its final rendered size is definitely correct. I see that wire only provides icons of 32x32 and 256x256 (on the AppImage i tried, /tmp/.mount_b6cHwU/usr/share/icons/default/) any particular example where the correct icon is actually provided and the final size is instead broken? another part of this problem, if i undesrtood correctly is that sometimes the icons provided are 24x24 pixels, so we should probably special case to try harder not to scale neither 22x22 nor 24x24 when the final size is near that All GTK-apps and Electron-apps have blurred icon on tray. Qt - works fine and looks very good. I don't know how this work. But GTK and Electron apps bad rendering on system tray. For example compare tray icons on Unity DE and Plasma - Unity also use 22px icon size for tray. For example Chrome icon on Unity: http://1.bp.blogspot.com/-faUUDw7x9BU/Uw-t40ofgNI/AAAAAAAARio/oWD7j8gyaz0/s1600/chrome-unstable-35-aura.png Skypeforlinux and Chrome on Plasma 5.8.2: https://2.bp.blogspot.com/--j9LBvp-0L8/WBDZkkNX5lI/AAAAAAAAHTE/0k-_95zE8_QVSojboCMzTgwRyUASVJqWgCLcB/s1600/Screenshot_20161026_191432.png You see - megasync (red icon), telegram (blue icon) - looks good. BUT chrome blurred and skypeforlinux it's ... hm i don't know waht is this. in order to enable a systray icon for chrome, do i need a particualr extension? It's native option use with libappindicator Created attachment 101928 [details]
compare
Please confirm this bug! See compare (attached file)
- Chrome icon not 22px used on Plasma tray.
- Wire wrong rendering
moving out of needsinfo Yes, on Wire use 24px icon size with wrong rendering. I found this file here: /tmp/.org.chromium.Chromium.19Eulp/icons/hicolor/24x24/apps/chrome_app_indicator2_56fbeb943aa705baef524e3ce5519a28.png And for Chrome too use 24px: /tmp/.com.google.Chrome.n7Lp9s/icons/hicolor/24x24/apps/chrome_app_indicator2_7cc1675d0780c4c41cc111531efd7b28.png Any news? Now Plasma 5.10.5 and this not fixed I tested it with one Electron app and can reproduce the issue, however, the icon it creates in /tmp/.org.chromium.Chromium.abcdef/icons is already cut off, no idea what Electron is doing here. This has been an ongoing problem for quite some time. Currently, on Fedora 25, 26, 27, The following apps that I use are affected causing my tray to look horrendous: 1. RocketChat+ - Electron 2. Riot - Electron 3. Wire - Electron 4. Keepass <- This one is NOT electron. (mono) Please fix this. Plasma 5.11.1 - it's not fixed :( KDE Neon, Plasma 5.11.2 the bug is still there when using googleplaymusicdesktopplayer. Hm, what kind of troubles does discourage plasma developers to fix this issue? Plasma 5.11.4 -- not fixed =( Icon good rendering if used Unity environment. For example: XDG_CURRENT_DESKTOP=Unity wire-desktop XDG_CURRENT_DESKTOP=Unity rocketchat RESULT: https://i.imgur.com/UXtJEDw.png This is a chromium bug. https://codereview.chromium.org/716253002 Committed:3 years, 1 month ago It's libappindicator/systemtray bug, because non-Electron apps have wrong rendering too. Run any application with libappindicator support and check this. No, it's an issue with Chromium. I've just sent a patchset there that fixes it: https://chromium-review.googlesource.com/c/chromium/src/+/1173235 |
