Bug 365924

Summary:	Breeze GTK should add shadows to context menus
Product:	[Plasma] Breeze	Reporter:	Kai Uwe Broulik <kde>
Component:	gtk theme	Assignee:	scionicspectre
Status:	RESOLVED DUPLICATE
Severity:	wishlist	CC:	bugseforuns, gianluca.pettinello, inglessi, nate, s_chriscollins
Priority:	HI
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Kai Uwe Broulik 2016-07-21 07:53:05 UTC

An application can request to have shadows painted around its window by KWin. This should be done by the GTK theme as well since otherwise the light-gray menus provide poor contrast above white contents.

See the [breeze.git] / kstyle / breezeshadowhelper.cpp for how the Breeze Qt style does this. It's basically some X properties and/or a wayland protocol that is given pixmaps for each corner.

Reproducible: Always

Comment 1 scionicspectre 2016-07-21 13:48:54 UTC

GTK 3 has certain issues of non-compliance with freedesktop.org standards which prevents a lot of these sorts of things from working properly in KWin. I'm not yet certain, but I think shadows around elements such as this would face the same issues we've seen with other elements like transparency and shadows around client-side decorations. GTK doesn't give the information for these boundaries in a way that reliably fits into KWin's structure.

I've been told that rewriting KWin to handle this could take months and there's no guarantee it wouldn't break again immediately as GTK 3 handles many of these things outside of any agreed upon standard or specification.

I'll look into it, but I think it's entirely likely we may have to accept this as a visual limitation until the broader issues surrounding GTK 3 are resolved.

Comment 2 Nate Graham 2017-05-08 19:27:20 UTC

In a related GTK bug report (https://bugzilla.gnome.org/show_bug.cgi?id=729794), Matthias Clasen--a lead GTK developer--says the following on this subject: 

"As you've found out, we already let the theme creators configure the applications appearance, including the shadows."

I may be misunderstanding the scope of work, but it doesn't seem like there are necessarily any KWin changes needed here: just some tweaks to the theme itself to tell KWin to always draw the shadows.

Comment 3 Gianluca Pettinello 2019-06-29 06:17:05 UTC

A bit of necrobump but I agree with Nate. The shadows should be created and drawn as for any other client simply ignoring what gtk has set as shadow properties

Comment 4 Nate Graham 2019-09-19 19:02:56 UTC

This requires _GTK_FRAME_EXTENTS support, which is now planned for KWin--in a way that doesn't break other things, of course. :) I'm hoping this lands in Plasma 5.18. Marking as a duplicate of the bug tracking that work.

*** This bug has been marked as a duplicate of bug 390550 ***