| Summary: | RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kwallet-pam | Reporter: | Damjan Georgievski <gdamjan> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version: | 5.7.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwallet-pam/d396744cc15b489e7cc74c30e9995423f17871a6 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | attempt to implement it | ||
Created attachment 100122 [details] attempt to implement it Here's a patch based on the master branch at https://github.com/KDE/kwallet-pam Git commit d396744cc15b489e7cc74c30e9995423f17871a6 by Albert Astals Cid, on behalf of Damjan Georgievski.
Committed on 21/01/2017 at 00:11.
Pushed by aacid into branch 'Plasma/5.9'.
use XDG_RUNTIME_DIR instead of /tmp for the socketPath
Most recent Linux distributions setup a per-user XDG_RUNTIME_DIR as a tmpfs, which is also tied to their session lifecycle. Typically this is in /run/user/1000/.
My suggestion is to use $XDG_RUNTIME_DIR/kwallet5.socket if XDG_RUNTIME_DIR exists, or fallback to /tmp/kwallet5_${username}.socket if it doesn't.
REVIEW: 129526
M +21 -11 pam_kwallet.c
https://commits.kde.org/kwallet-pam/d396744cc15b489e7cc74c30e9995423f17871a6
|
Most recent Linux distributions setup a per-user XDG_RUNTIME_DIR as a tmpfs, which is also tied to their session lifecycle. Typically this is in /run/user/1000/. My suggestion is to use $XDG_RUNTIME_DIR/kwallet5.socket if XDG_RUNTIME_DIR exists, or fallback to /tmp/kwallet5_${username}.socket if it doesn't. Reproducible: Always