Bug 365705

Summary: KWrite ignores .kateconfig eol option
Product: [Applications] kate Reporter: Jennifer <jennifertf3>
Component: kwriteAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: major    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Debian stable   
OS: Linux   
Latest Commit: http://commits.kde.org/ktexteditor/07b003e5a87b44d4618204bbcff257c59a446025 Version Fixed/Implemented In:
Sentry Crash Report:

Description Jennifer 2016-07-15 06:18:27 UTC 
In Settings --> Configure Editor --> Open/Save I have end of line set to UNIX.  In /ddisk/.kateconfig I had "eol dos", "Kate: eol dos", or "// Kate: eol dos" (I tried it all three ways).  If I create a new file with KWrite and save it, it is save with unix-style end-of-lines (\n, not \r\n).

If I open an existing file and select Tools --> End of line, it always shows up as UNIX.  My expectation is that any file saved under /ddisk (a mounted partition shared with Windows) should be saved with \r\n at the end of each line.  Specifically, .kateconfig should override Settings --> Configure Editor --> Open/Save --> End of line.

Automatic end of line detection is unchecked.

I'm using KWrite 4.14.2 (there is no option in the drop-down box for 4.14.2 and there is no text box to enter the version manually).


Reproducible: Always

Steps to Reproduce:
1. Set Settings --> Configure Editor --> Open/Save --> End of line to UNIX.
2. In a top-level directory, save a .kateconfig file containing "eol unix".
3. Save a file there, or edit an existing file and save it.
4. Examine this file with a hex editor such as Bless.

Actual Results:  
End of lines showed up as hex 0A.

Expected Results:  
End of lines should show up as hex 0D0A.

I'm running Debian Jessie with the MATE desktop.  I installed KWrite, which pulled in katepart and a lot of other stuff, but I didn't install Kate proper.

The ability to save files with either UNIX or DOS end-of-lines, depending on where I save it, is important to me.
Comment 1 Jennifer 2016-07-29 18:54:47 UTC 
(In reply to Jennifer from comment #0)
> In Settings --> Configure Editor --> Open/Save I have end of line set to
> UNIX.  In /ddisk/.kateconfig I had "eol dos", "Kate: eol dos", or "// Kate:
> eol dos" (I tried it all three ways).  If I create a new file with KWrite
> and save it, it is save with unix-style end-of-lines (\n, not \r\n).
> 
> If I open an existing file and select Tools --> End of line, it always shows
> up as UNIX.  My expectation is that any file saved under /ddisk (a mounted
> partition shared with Windows) should be saved with \r\n at the end of each
> line.  Specifically, .kateconfig should override Settings --> Configure
> Editor --> Open/Save --> End of line.
> 
> Automatic end of line detection is unchecked.
> 
> I'm using KWrite 4.14.2 (there is no option in the drop-down box for 4.14.2
> and there is no text box to enter the version manually).
> 
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Set Settings --> Configure Editor --> Open/Save --> End of line to UNIX.
> 2. In a top-level directory, save a .kateconfig file containing "eol dos".
> 3. Save a file there, or edit an existing file and save it.
> 4. Examine this file with a hex editor such as Bless.
> 
> Actual Results:  
> End of lines showed up as hex 0A.
> 
> Expected Results:  
> End of lines should show up as hex 0D0A.
> 
> I'm running Debian Jessie with the MATE desktop.  I installed KWrite, which
> pulled in katepart and a lot of other stuff, but I didn't install Kate
> proper.
> 
> The ability to save files with either UNIX or DOS end-of-lines, depending on
> where I save it, is important to me.
Comment 2 Jennifer 2016-07-29 18:56:26 UTC 
Step 2 of how to recreate was corrected from "eol unix" to "eol dos"
Comment 3 Christoph Cullmann 2016-09-06 20:48:34 UTC 
Git commit 07b003e5a87b44d4618204bbcff257c59a446025 by Christoph Cullmann.
Committed on 06/09/2016 at 20:48.
Pushed by cullmann into branch 'master'.

fix eol setting in mode lines
turn off auto-detection if set

M  +5    -0    src/document/katedocument.cpp

http://commits.kde.org/ktexteditor/07b003e5a87b44d4618204bbcff257c59a446025