Summary: | KWin crashes when switching rendering backend with QPainter scene | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Fabian Vogt <fabian> |
Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | Flags: | mgraesslin:
ReviewRequest+
|
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
URL: | https://phabricator.kde.org/D2185 | ||
Latest Commit: | http://commits.kde.org/kwin/0286882b3f80b3b68f904dc5d6721e0da640712a | Version Fixed In: | 5.7.3 |
Description
Fabian Vogt
2016-07-12 15:26:58 UTC
The actual problem is that we don't even support switching the backend yet and will never support that on Wayland for the running session. It should not be possible to restart the compositor. (In reply to Martin Gräßlin from comment #1) > The actual problem is that we don't even support switching the backend yet > and will never support that on Wayland for the running session. It should > not be possible to restart the compositor. actually that's nonesense. We need to be able to survive a restart of the compositor. That's needed for handleGraphicsReset in OpenGL compositor. Patch against master (due to newer test only in master branch): https://phabricator.kde.org/D2185 Will backport the part without the patch also to Plasma/5.7 branch. Git commit 3308f359848fc193b3c9d222179bc58136bea834 by Martin Gräßlin. Committed on 21/07/2016 at 06:11. Pushed by graesslin into branch 'master'. Handle restart of Compositor Scene correctly for Wayland client Summary: This change ensures that KWin doesn't crash in the QPainter scene if the compositor gets restarted and if there are Wayland clients. Test Plan: Test case added to scene qpainter which triggers a restart of the Compositor with a window being shown. Verifies that rendering is correct afterwards. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2185 M +53 -0 autotests/integration/scene_qpainter_test.cpp M +7 -0 composite.cpp http://commits.kde.org/kwin/3308f359848fc193b3c9d222179bc58136bea834 Git commit 0286882b3f80b3b68f904dc5d6721e0da640712a by Martin Gräßlin. Committed on 21/07/2016 at 06:13. Pushed by graesslin into branch 'Plasma/5.7'. Handle restart of Compositor Scene correctly for Wayland client Summary: This change ensures that KWin doesn't crash in the QPainter scene if the compositor gets restarted and if there are Wayland clients. Cherry-picked from master FIXED-IN: 5.7.3 Test Plan: Test case added to scene qpainter which triggers a restart of the Compositor with a window being shown. Verifies that rendering is correct afterwards. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2185 M +7 -0 composite.cpp http://commits.kde.org/kwin/0286882b3f80b3b68f904dc5d6721e0da640712a |