Bug 365204

Created attachment 99928 [details]
Kickoff menu with messup up icons

Kickoff menu is also affected. Some icons are taken from Breeze them, some from Oxygen.

Created attachment 99929 [details]
Patch to make kicker and kickoff use icons from icon theme

Not sure if it's desired behaviour for upstream. But as it makes Kicker and Kickoff look consistent, I'll apply it to ROSA's Plasma Desktop package.

At least in Kicker's case, the system favorites are supposed to use the Plasma theme. The Kickoff patch might be valid, please submit it via Phab.

(In reply to Eike Hein from comment #3)
> At least in Kicker's case, the system favorites are supposed to use the Plasma theme. 

Why does it use Breeze icons if Plasma theme is set to Oxygen? Is it a Plasma bug?

> The Kickoff patch might be valid, please submit it via Phab.

https://git.reviewboard.kde.org/r/128392/

Maybe the Oxygen theme has no icons.

(In reply to Eike Hein from comment #5)
> Maybe the Oxygen theme has no icons.

Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot" etc in /usr/share/plasma/desktoptheme/*/icons/ (plasma theme) directories. And both have such icons in /usr/share/icons/* (icon theme) directories.

There's a chance that using Breeze icon theme as fallback (if there's no selected icon in plasma theme) is hardcoded somewhere.

> Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot"

In fact, they both have such elements in start.svgz. Maybe plasma-frameworks's IconItem::setSource function is buggy then.

(In reply to Pulfer from comment #6)
> (In reply to Eike Hein from comment #5)
> > Maybe the Oxygen theme has no icons.
> 
> Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot"
> etc in /usr/share/plasma/desktoptheme/*/icons/ (plasma theme) directories.

The corresponding icons are/should be in usr/share/plasma/desktoptheme/*/icons/system.svgz.
They were missing in Oxygen and Air, and have been (will be) added in KDE Frameworks 5.24.0:
https://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=7379b9b830848e09defee17b362ac10852a4f4be

> There's a chance that using Breeze icon theme as fallback (if there's no
> selected icon in plasma theme) is hardcoded somewhere.

Yes, if the desktop/plasma theme is missing icons, they are taken from the "default" plasma theme (i.e. Breeze) instead.

(In reply to Pulfer from comment #7)
> > Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot"
> 
> In fact, they both have such elements in start.svgz. Maybe
> plasma-frameworks's IconItem::setSource function is buggy then.

start.svgz is only used for application launcher "icon" itself AFAIK.

(In reply to Wolfgang Bauer from comment #8)
> They were missing in Oxygen and Air, and have been (will be) added in KDE
> Frameworks 5.24.0:
> https://quickgit.kde.org/?p=plasma-framework.
> git&a=commit&h=7379b9b830848e09defee17b362ac10852a4f4be

Actually that is in 5.23.0 already, and it does work fine here: if I set Oxygen or Air as desktop theme, the system favorites and Kickoff's tabs use indeed Oxygen icons.

The other icons for Kickoffs tabs are in bookmarks.svgz, applications.svgz, computer.svgz and view.svgz (should also be in /usr/share/plasma/desktop-theme/*/icons/).

(In reply to Wolfgang Bauer from comment #8)
> > In fact, they both have such elements in start.svgz. Maybe
> > plasma-frameworks's IconItem::setSource function is buggy then.
> 
> start.svgz is only used for application launcher "icon" itself AFAIK.

Sorry, I meant system.svgz. BTW, please check system.svgz from air theme. I guess there's a typo there ("system-user" element instead of "system-users").

As for application launcher icon, sometimes it uses icon from Plasma theme, sometimes from icons theme (icon may change after system reboot). 

I recorded a video where it's possible to see that launcher icon on panel is used from icons theme, not from plasma theme (sorry for non-English Plasma interface but it shouldn't matter): https://disk.yandex.ru/client/disk

Ignore kicker favorite system actions icons on video, they are patched to use icons theme. Also note that I replaced start-here-kde from Breeze icons theme (color dots) with icon from Breeze plasma theme ("K"). But it's clear that launcher uses Breeze icons theme icon if I switch desktop theme to Oxygen.

(In reply to Pulfer from comment #10)
> I recorded a video where it's possible to see that launcher icon on panel is
> used from icons theme, not from plasma theme (sorry for non-English Plasma
> interface but it shouldn't matter): https://disk.yandex.ru/client/disk

Correct URL: https://yadi.sk/i/GxaIPQUBt8nBa

(In reply to Pulfer from comment #10)
> Sorry, I meant system.svgz. BTW, please check system.svgz from air theme. I
> guess there's a typo there ("system-user" element instead of "system-users").

No, works fine here.

Maybe a caching issue?
Try to delete ~/.cache/plasma* when Plasma is not running.

But as mentioned, I cannot reproduce your problem here on openSUSE...

> As for application launcher icon, sometimes it uses icon from Plasma theme,
> sometimes from icons theme (icon may change after system reboot). 

I noticed this when I change themes, it still uses the old one.
But after restarting plasmashell, this is ok.

PS: changing "Look and Feel" apparently doesn't work fully in 5.7.0.
I can confirm that.

But probably worth a specific bug report.

(In reply to Wolfgang Bauer from comment #12)
> (In reply to Pulfer from comment #10)
> > Sorry, I meant system.svgz. BTW, please check system.svgz from air theme. I
> > guess there's a typo there ("system-user" element instead of "system-users").
> 
> No, works fine here.
> 
> Maybe a caching issue?
> Try to delete ~/.cache/plasma* when Plasma is not running.

Likely it's caused by https://bugs.kde.org/show_bug.cgi?id=365363 (System Setting may damage icons cache)

Ok, you're right, sorry.
I can reproduce your problem now:
When switching the desktop theme to Air or Oxygen, Kickoff indeed takes some icons from the icon theme (to be precise, the icons for the Favorites, Applications, and Computer tabs, and the application launcher icon itself).
Not sure why I didn't see that before, maybe I switched the icon theme as well when I tested it...

This seems  to be a problem/bug in those desktop themes though, not in Plasma or Kickoff.
If I set Breeze as desktop theme and switch the icon theme to Oxygen, those icons are still Breeze (i.e. they are in fact taken from the desktop theme).

Another problem is that switching the icon theme has no effect on running applications (including Plasma), but there is a bug report about that I think.

I am not sure about your review request though.
On the one hand you "complain" that some icons are taken from the icon theme, and you want to fix that by taking *all* icons from the icon theme? ;-)
The desktop themes should be fixed IMHO.

Though personally I do agree that it can be confusing that some icons are taken from the icon theme, while others are taken from the desktop theme.

(In reply to Pulfer from comment #14)> Likely it's caused by https://bugs.kde.org/show_bug.cgi?id=365363 (System
> Setting may damage icons cache)

Not really.
The Plasma theme cache is independent from the icon cache (which is in ~/.cache/icon-cache.kcache).
I definitely don't see that problem you describe there.
And AFAIK, the icon module actually deletes the icon cache when you switch to a different theme.

(In reply to Wolfgang Bauer from comment #16)
> I am not sure about your review request though.
> On the one hand you "complain" that some icons are taken from the icon
> theme, and you want to fix that by taking *all* icons from the icon theme?
> ;-)

I rather "complain" that in general menu plasmoids' contents look inconsistent because of mixed icon sources. The only exception is desktop themes having the same icons as icon themes. But in such cases it works the same way as if "usesPlasmaTheme: false" was set.

> The desktop themes should be fixed IMHO.

IMHO, it's more plasmoid design issue than theme bug. If there are 2 buttons with the same action in an application ("Poweroff " etc buttons in menu), likely they should look the same. 

> And AFAIK, the icon module actually deletes the icon cache when you switch to a different theme.

At least in System Settings' case SS keeps "thinking" that old icons theme is still used (if you press back button instead of closing SS with KCM icons after applying new icons theme). So it inserts icons from older theme to icons cache. Maybe some other applications do the same. But likely it's better to discuss in #365363 anyway...

(In reply to Pulfer from comment #17)
> IMHO, it's more plasmoid design issue than theme bug. If there are 2 buttons
> with the same action in an application ("Poweroff " etc buttons in menu),
> likely they should look the same. 

Yes, this general inconsistency is a plasma design "issue" if you will.
There is another bug report about this IIRC (I'm not sure if it is still open or has been closed, can't find it at the moment).

But that Kickoff's tab icons and the launcher icon itself are taken from the icon theme in these particular cases is a bug in the themes, which should be fixed in the themes.

> At least in System Settings' case SS keeps "thinking" that old icons theme
> is still used

That's unrelated to the icon cache though IMHO.
Rather sounds like a problem with actually saving the selected icon theme to kdeglobals to me...
But yes, this should not really be discussed here.

(In reply to Wolfgang Bauer from comment #15)
> I can reproduce your problem now:
> When switching the desktop theme to Air or Oxygen, Kickoff indeed takes some
> icons from the icon theme (to be precise, the icons for the Favorites,
> Applications, and Computer tabs, and the application launcher icon itself).

I'm reopening this bug report therefore, and re-assign it to plasma-framework (which contains the desktop themes).

I had a look at applications.svgz in inkscape. The Breeze version contains the icon as object group that's named "applications-other", while the Air version doesn't have something like this and I think that's the reason why Plasma doesn't find the icon and falls back to take it from the icon theme.
And indeed, after changing this, that "Applications" icon is fixed (I had to delete the Plasma cache though).

Haven't checked the other affected ones yet, but I suspect a similar problem there.
system.svgz is fine though.

Also CC'ing Andreas Kainz who added those icons in the first place...

FWICT so far, these files are affected (in the Air and Oxygen desktop themes):
start.svgz, bookmarks.svgz, applications.svgz, computer.svgz

(In reply to Wolfgang Bauer from comment #19)
> Haven't checked the other affected ones yet, but I suspect a similar problem
> there.
> system.svgz is fine though.

Please check system.svgz from Air theme. As I wrote in comment 10, I guess there's a typo there ("system-user" element used instead of "system-users").

(In reply to Pulfer from comment #20)
> (In reply to Wolfgang Bauer from comment #19)
> > Haven't checked the other affected ones yet, but I suspect a similar problem
> > there.
> > system.svgz is fine though.
> 
> Please check system.svgz from Air theme. As I wrote in comment 10, I guess
> there's a typo there ("system-user" element used instead of "system-users").

And why do you think that is a typo or even matters?
As I said, system.svgz works fine here.
That particular icon is not even used anywhere AFAICS (please correct me if I'm wrong), "Switch User" uses system-switch-user, not system-user(s).
There are 8 icons in system.svgz, but only 7 entries in Kickoff's "Leave" tab.

But ok, maybe this should be changed as well, if only for consistency.

Just to avoid a misunderstanding here though: only the icons in Kicker's "system favorites" section on the left are taken from the desktop theme.
The icons in the "Powermanagement / Session" submenu are taken from the icon theme, like all other icons in all other submenus. And the same is true for Kickoff's "Leave" tab. This is not a problem of the desktop theme.

(In reply to Wolfgang Bauer from comment #18)
> Yes, this general inconsistency is a plasma design "issue" if you will.
> There is another bug report about this IIRC (I'm not sure if it is still
> open or has been closed, can't find it at the moment).

I was thinking of Bug#348299 here.

I just noticed that system-save-session is missing from system.svgz in Air/Oxygen though.

(In reply to Wolfgang Bauer from comment #22)
> I just noticed that system-save-session is missing from system.svgz in
> Air/Oxygen though.

And apparently it's missing from the Oxygen icon theme too.

ok what's the problem

oxygen/air plasma theme is unmaintained it was removed in 5.6 we add it cause I say there are people out there how will use it.

but there are no oxygen icon designers available since the last 4 years. It is hard, but that's live.

about the system.svgz icons. Chakra forked breeze-icons cause they don't want to use the breeze shutdown, restart, ... icons.

I also don't understand why some icons are from breeze-icons and some are from the plasma theme, but the plasma developers will have an argument for it. In addition we can live with it. system-save-session is disabled by default. I fixed the issues with the kickoff menu in 5.7 so everything is fine.

(In reply to Wolfgang Bauer from comment #21)
> > Please check system.svgz from Air theme. As I wrote in comment 10, I guess
> > there's a typo there ("system-user" element used instead of "system-users").
> 
> And why do you think that is a typo or even matters?

It's a typo because the proper icon name is "system-users", not "system-user":
/usr/share/icons/Adwaita/32x32/apps/system-users.png
/usr/share/icons/breeze/apps/32/system-users.svg
/usr/share/icons/gnome/32x32/apps/system-users.png
/usr/share/icons/oxygen/base/32x32/apps/system-users.png
etc (including system.svgz from Breeze).

Only in Air's system.svgz it's "system-user".

> That particular icon is not even used anywhere AFAICS

There's a chance that some plasmoid will try to use it in future. It's not related to Kicker/Kickoff, just a general Air theme bug.

The proposed patch does not work because it results in Kickoff using icons from the Breeze icon theme instead of the Breeze Plasma theme, and some of them are different and don't look as good.

There is no problem with Kickoff here; it seems that issue is that the Oxygen Plasma theme lacks icons, so Kickoff falls back to the Breeze theme.