Bug 365111

Summary:	Widgets explorer is missing a lot of icons for its items
Product:	[Plasma] plasmashell	Reporter:	soee <kontakt>
Component:	general	Assignee:	David Edmundson <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bshah, notmart, plasma-bugs-null, rikmills
Priority:	NOR
Version First Reported In:	5.6.95
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
URL:	https://youtu.be/yYed-56WJmw
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Missing icons in widgets explorer Missing icon in systray example on Clementine

Description soee 2016-07-05 15:56:15 UTC

As presented on the video (see attached link) widgets  explorer items are missing their unique icons. We see blank document icons instead.

Reproducible: Always

Steps to Reproduce:
1. Open widgets explorer
2. See a lot of missing icons (white document icon instead)
3.

Actual Results:  
We see a lot of missing icons wor presented widgets.

Expected Results:  
Each widget in the explorer shoudl have own, unique icon.

Comment 1 Marco Martin 2016-07-05 15:58:16 UTC

screenshot?

Comment 2 soee 2016-07-05 16:02:51 UTC

(In reply to Marco Martin from comment #1)
> screenshot?

There is a link to video in this bug report but ok here is the screenshot:

Comment 3 soee 2016-07-05 16:03:32 UTC

Created attachment 99862 [details]
Missing icons in widgets explorer

Comment 4 Rik Mills 2016-07-05 16:11:06 UTC

Can confirm I am seeing the same in Neon user edition. Plasma 5.7.0.

Comment 5 David Edmundson 2016-07-05 16:12:03 UTC

It's lower level than icon item and icon cache

icon item  sources set to  QVariant(QString, "list-remove")

instead of the normal: 
icon item  sources set to  QVariant(QIcon, QIcon("org.kde.plasma.kickoff",availableSizes[normal,Off]=(QSize(16, 16), QSize(22, 22), QSize(32, 32), QSize(48, 48), QSize(64, 64), QSize(128, 128), QSize(256, 256)),cacheKey=0x1e500000000))

Can reproduce it here, so I'll fix it.

Comment 6 David Edmundson 2016-07-05 16:38:44 UTC

Edit: got confused by my own debug - that icon is for the remove button in the corner

The ones where we have no icon are cases where we don't have the proper icon in breeze - however it should be falling back to the icon name in the metadata file.  That's not happening though.

Comment 7 David Edmundson 2016-07-05 16:47:57 UTC

QIcon::hasThemeIcon is broken.

Will need a fix in Qt /o\

Comment 8 soee 2016-07-06 03:23:11 UTC

Also various applications (liek Clementine) are missing icon when docked in systray - we see only blank page icon. Is this related to this bug or shall i open new one?

Comment 9 soee 2016-07-06 03:40:14 UTC

Created attachment 99874 [details]
Missing icon in systray example on Clementine

This is how the missing icon looks in systry

Comment 10 David Edmundson 2016-12-08 17:00:18 UTC

This was fixed by David Rosca with some commit in KIconThemes.