Bug 365053

Summary:	Icon overlay discards origin
Product:	[Frameworks and Libraries] frameworks-kguiaddons	Reporter:	gandolfi rafael <kaillasse91>
Component:	general	Assignee:	gandolfi rafael <kaillasse91>
Status:	CONFIRMED ---
Severity:	normal	CC:	kaillasse91
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	correct overlay drawing position Self-contained test cases to illustrate the bug and the proposed patch. Screenshot of KIconUtils::addOverlay with and without the patch Self-contained test cases to illustrate the bug and the proposed patch updated with current kguiaddons

Description gandolfi rafael 2016-07-03 23:30:38 UTC

The origin is discarded in KOverlayIconEngine::paint which result in badly placed overlay, p.e. if you're drawing the icon in a QAbstractItemView.

Reproducible: Always

Steps to Reproduce:
1. Create a simple class derived from QAbstractItemModel
2. In data() for Qt::DecorationRole, overlay the icons with KIconUtils::addOverlay
3. Put the model in a QTreeView

Actual Results:  
The overlay is rendered in non sensical possition when I've managed to spot it.

Expected Results:  
the overlay rendered at the expected position in the base icon.

I'll attached a patch which fixes the issue as I understood it.

Comment 1 gandolfi rafael 2016-07-03 23:32:40 UTC

Created attachment 99840 [details]
correct overlay drawing position

Comment 2 gandolfi rafael 2016-07-21 00:03:56 UTC

Created attachment 100221 [details]
Self-contained test cases to illustrate the bug and the proposed patch.

Comment 3 gandolfi rafael 2016-07-25 22:38:46 UTC

Created attachment 100303 [details]
Screenshot of KIconUtils::addOverlay with and without the patch

Comment 4 Justin Zobel 2022-10-21 23:59:41 UTC

Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!

Comment 5 gandolfi rafael 2022-10-22 18:18:47 UTC

Created attachment 153125 [details]
Self-contained test cases to illustrate the bug and the proposed patch updated with current kguiaddons

The bug is still present with the current kguiaddons. I used the version hosted at https://github.com/KDE/kguiaddons updated 3 days ago.
You can use the updated test case attached to confirm it by yourself. 
If this is not the place to report this bug or if you want me to submit a patch directly feel free to tell me.