Bug 364957

Summary: Add a pause button in multimedia preview panel
Product: [Applications] dolphin Reporter: Matthias <shalokshalom>
Component: panels: informationAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: meven29, nate
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:

Description Matthias 2016-07-01 06:01:06 UTC 
Dolphin can be a very nice music player to some of us - one of the two things, which block that use case currently, is that there is currently no way to pause the playback and succeed then :)


Reproducible: Always

Steps to Reproduce:
1. Open Dolphin and open the info sidebar if not open yet (F11)
2. Hover over a music file
3. Press play
4. Try to pause the playback

Actual Results:  
there is no pause button

Expected Results:  
there is a button to pause and resume the playback 

I see one single reason, to let the stop button, which is already implemented, coexist with the new pause button and that is once "one click to open files" is enabled and this feature request here gets complied and the described option is enabled: 

https://bugs.kde.org/show_bug.cgi?id=364956 

Since then is no way left anymore, to choose another file in order to play that one in the info panel. So, most sane solution is imho to replace the stop button with a play/resume button and implement one more feature: 

Case 1 "single click to open" is set

a single click on a file while the playback is paused, stop the playback

Case 2 "double click to open" is set

all is fine

Reproducible: Always

Steps to Reproduce:
1. Open Dolphin and its info panel
2. Hover over a music/video file and press play in the info panel
3. try to pause and resume

Actual Results:  
there is no pause/resume button

Expected Results:  
there is a pause/resume button
Comment 1 Méven Car 2019-09-01 15:45:23 UTC 
Fixed through https://phabricator.kde.org/D22183 : you can click on the icon, preview or video playback to pause the playback.

A patch to replace to stop button by a pause button is underway :
https://phabricator.kde.org/D23648
Comment 2 Méven Car 2019-09-02 05:00:38 UTC 
Git commit 9996b1f89c70b00427477c98abe93c5696d993c6 by Méven Car.
Committed on 02/09/2019 at 05:00.
Pushed by meven into branch 'master'.

Replace the stop button of the media preview by a pause button

Summary:
Stop is not as useful as paused plus it makes the button coherent with the click to play/pause feature.

Test Plan: {F7305382}

Reviewers: #dolphin, elvisangelaccio, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D23648

M  +21   -16   src/panels/information/phononwidget.cpp
M  +3    -1    src/panels/information/phononwidget.h

https://commits.kde.org/dolphin/9996b1f89c70b00427477c98abe93c5696d993c6