Bug 364793

Git commit 2bea66e9401f2bccd712938bab7c1c24073d2e15 by Gilles Caulier.
Committed on 27/06/2016 at 10:08.
Pushed by cgilles into branch 'master'.

text-xml -> format-text-code

M  +1    -1    libs/imageproperties/imagepropertiessidebar.cpp
M  +1    -1    libs/imageproperties/imagepropertiessidebarcamgui.cpp
M  +1    -1    libs/widgets/mainview/dxmlguiwindow.cpp
M  +1    -1    showfoto/setup/showfotosetup.cpp
M  +1    -1    utilities/advancedrename/parser/options/metadataoption.cpp
M  +1    -1    utilities/assistants/firstrun/metadatapage.cpp
M  +1    -1    utilities/queuemanager/basetools/metadata/removemetadata.cpp
M  +1    -1    utilities/setup/setup.cpp

http://commits.kde.org/digikam/2bea66e9401f2bccd712938bab7c1c24073d2e15

Git commit 2ea87bbd47d2f1503f5c2ff354a766f0590e51fd by Gilles Caulier.
Committed on 27/06/2016 at 10:10.
Pushed by cgilles into branch 'master'.

applications-internet -> internet-web-browser

M  +1    -1    app/filters/filtersidebarwidget.cpp
M  +1    -1    app/main/digikamapp.cpp
M  +1    -1    app/views/leftsidebarwidgets.cpp
M  +1    -1    app/views/tableview/tableview_column_geo.cpp
M  +1    -1    libs/imageproperties/imagepropertiessidebar.cpp
M  +1    -1    libs/imageproperties/imagepropertiessidebarcamgui.cpp
M  +1    -1    libs/models/albummodel.cpp
M  +1    -1    libs/template/templatepanel.cpp
M  +1    -1    libs/template/templateviewer.cpp
M  +1    -1    libs/widgets/itemview/itemviewimagedelegate.cpp
M  +1    -1    libs/widgets/mainview/dxmlguiwindow.cpp
M  +1    -1    showfoto/thumbbar/itemviewshowfotodelegate.cpp
M  +1    -1    tests/geolocation/geoiface/demo/mainwindow.cpp
M  +1    -1    utilities/geolocation/editor/dialog/geolocationedit.cpp
M  +1    -1    utilities/geolocation/geoiface/mapwidget.cpp
M  +1    -1    utilities/importui/items/itemviewimportdelegate.cpp
M  +1    -1    utilities/importui/main/importui.cpp
M  +1    -1    utilities/metadataedit/iptc/iptceditwidget.cpp

http://commits.kde.org/digikam/2ea87bbd47d2f1503f5c2ff354a766f0590e51fd

Git commit d2f719254fb4179445c1efa341da14fe85804365 by Gilles Caulier.
Committed on 27/06/2016 at 10:11.
Pushed by cgilles into branch 'master'.

applications-internet -> internet-web-browser
FIXED-IN: 5.0.0

M  +1    -1    facebook/fbalbum.cpp
M  +1    -1    facebook/fbwindow.cpp
M  +1    -1    yandexfotki/plugin_yandexfotki.cpp

http://commits.kde.org/kipi-plugins/d2f719254fb4179445c1efa341da14fe85804365

I noticed that the map icon still is the only icon not in monochrome and really stands out. I guess the right icon instead of "internet-web-browser" is "globe". It is essentially the same item as is in use currently, but in monochrome. There is also "map-globe", but in my opinion it is ugly. "globe" only exists in sizes 16 and 22, but as it is just a symlink to "folder-html"  which exists in all sizes this should be easily added if necessary.

Hi, yes global would be the best joice cause you use the icon for actions. action icons are needed in 22px by default and 16px if the user like. I also play around with 32px size but nobody care about 32px action icons. so change to global

thanks
Andreas

Hi Andreas,
There are other icons that stand out as not monochrome, however less 
present and much less intrusive. Still making them monochrome too would 
only be consistent. Are there already monochrome pendants to the 
following icons?
In the right sidebar:
  - in Filters: MIME Type Filtering
  - in Captions/Tags: rider Information: Rights
  - in Properties: Item Properties and Photograph Properties
In the left sidebar:
  - in Dates: icons of subentries of years

On 20/07/16 11:03, andreas via KDE Bugzilla wrote:
> https://bugs.kde.org/show_bug.cgi?id=364793
>
> --- Comment #5 from andreas <kainz.a@gmail.com> ---
> Hi, yes global would be the best joice cause you use the icon for actions.
> action icons are needed in 22px by default and 16px if the user like. I also
> play around with 32px size but nobody care about 32px action icons. so change
> to global
>
> thanks
> Andreas
>

Sorry about the multiple mails, but while I am at it there are also some 
colored icons in the menus, some of which may also be intentianally colored:
  - Browse/Quit
  - Album
    - Rename
    - Delete Album
  - Item/Open With Default Application
  - Import
    - Cameras
    - Import from Scanner...
    - Import from Google Photos/Picasaweb
  - Export/ almost all of them
  - Settings/Configure Notifications
  - Help
    - Supported RAW Cameras
    - Kipi Plugins Handbook
    - About digiKam

On 20/07/16 11:12, Simon via KDE Bugzilla wrote:
> https://bugs.kde.org/show_bug.cgi?id=364793
>
> --- Comment #6 from Simon <freisim93@gmail.com> ---
> Hi Andreas,
> There are other icons that stand out as not monochrome, however less
> present and much less intrusive. Still making them monochrome too would
> only be consistent. Are there already monochrome pendants to the
> following icons?
> In the right sidebar:
>    - in Filters: MIME Type Filtering
>    - in Captions/Tags: rider Information: Rights
>    - in Properties: Item Properties and Photograph Properties
> In the left sidebar:
>    - in Dates: icons of subentries of years
>
> On 20/07/16 11:03, andreas via KDE Bugzilla wrote:
>> https://bugs.kde.org/show_bug.cgi?id=364793
>>
>> --- Comment #5 from andreas <kainz.a@gmail.com> ---
>> Hi, yes global would be the best joice cause you use the icon for actions.
>> action icons are needed in 22px by default and 16px if the user like. I also
>> play around with 32px size but nobody care about 32px action icons. so change
>> to global
>>
>> thanks
>> Andreas
>>

can I make a Digikam review and if I can fix it I will send an Review Request via RB ok.

Don't need to use RB. A patch posted to bugzilla is enough.

As i already said in the past, RB is a waste time. Bugzilla is enough and is perfect to manage an open source project. Just attach the patch to a new bugzilla entry.

I don't understand why we need to multiply tools to manage opensource. One to drive all is enough. Improving Bugzilla yes, multiply tools no, excepted if a tool provide something new and suitable.

For a simple patch to review, bugzilla is enough. In all case we will need to donwload the patch to test...

Gilles Caulier

Note: The icon globe does not work under Windows, always use the unlinked variant -> folder-html.

Maik

Git commit 9bd54c20a5b51736f2d17139c7103c680ce4a233 by Maik Qualmann.
Committed on 07/08/2016 at 08:10.
Pushed by mqualmann into branch 'master'.

fix icons

M  +1    -1    app/filters/filtersidebarwidget.cpp
M  +2    -2    app/main/digikamapp.cpp
M  +1    -1    app/views/leftsidebarwidgets.cpp
M  +1    -1    app/views/tableview/tableview_column_geo.cpp
M  +1    -1    libs/database/collection/collectionmanager.cpp
M  +1    -1    libs/imageproperties/imagepropertiesgpstab.cpp
M  +1    -1    libs/imageproperties/imagepropertiessidebar.cpp
M  +1    -1    libs/imageproperties/imagepropertiessidebarcamgui.cpp
M  +1    -1    libs/models/albummodel.cpp
M  +1    -1    libs/template/templatepanel.cpp
M  +1    -1    libs/template/templateviewer.cpp
M  +1    -1    libs/widgets/itemview/itemviewimagedelegate.cpp
M  +4    -4    libs/widgets/mainview/dxmlguiwindow.cpp
M  +1    -1    showfoto/thumbbar/itemviewshowfotodelegate.cpp
M  +1    -1    tests/geolocation/geoiface/demo/mainwindow.cpp
M  +1    -1    utilities/geolocation/editor/dialog/geolocationedit.cpp
M  +1    -1    utilities/geolocation/geoiface/mapwidget.cpp
M  +1    -1    utilities/importui/items/itemviewimportdelegate.cpp
M  +1    -1    utilities/importui/main/importui.cpp
M  +1    -1    utilities/metadataedit/iptc/iptceditwidget.cpp
M  +2    -2    utilities/setup/collections/setupcollectionview.cpp

http://commits.kde.org/digikam/9bd54c20a5b51736f2d17139c7103c680ce4a233

Created attachment 103072 [details]
Replace more icons that stand out

There is still some icons which stand out for not being monochrome in the wrong context. I did the following changes in the attached patch:

view-calendar-month -> view-calendar (Dates sidebar, context menu goto date)
system-file-manager -> folder-open (filters MIME)
applications-graphics -> document-edit (tools sidebar)
flag-red -> flag (only where applicable)
image-x-generic -> view-preview (item properties)
folder-html -> view-bank (for donate menu entry)
folder-html -> globe (geolocation related stuff)

I made sure all were files not symlinks.
I was in contact with the maintainer of breeze and they were almost upset over folder-html (a folder icon) being used instead of globe (action icon) so they immediately made the globe icons actual files and the folder-html to symlinks (without me being able to consult with you first), see
https://bugs.kde.org/show_bug.cgi?id=374307
and
https://github.com/KDE/breeze-icons/commit/1067bcbae8a03df42ca415aee28c255915eb2056
Using folder-html had the ugly effect, that in the tools sidebar the geolocation icon was a blue folder in the middle of monochrome folders. This is fixed by switching back to globe.

Created attachment 103073 [details]
Replace more icons that stand out (corrected)

The previous patch was old, sorry.

Simon,

Thanks for your patch. Please open a new file in bugzilla to attach your patch. This one have been closed few month ago. Mixing patches here can confuse the history.

Thanks in advance

Gilles Caulier