Bug 364510

Summary: 16.04 - git - Position and Zoom "Original Size" icon not working
Product: [Applications] kdenlive Reporter: Evert Vorster <evorster>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal CC: wegwerf-1-2-3
Priority: NOR    
Version First Reported In: 16.04.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Other   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Evert Vorster 2016-06-19 15:02:48 UTC
When I am editing 4K footage in an HD project, when I hit this button I expect the footage to be zoomed to 200%. 
This also used to be the behavior of this icon. Right now it seems more like it fits the footage to the project's resolution

Reproducible: Always

Steps to Reproduce:
1.Load 4K footage in HD project
2.Add Position and Zoom effect to clip
3.Hit the "Zoom to original Size" icon

Actual Results:  
Footage is fitted to the project size. 

Expected Results:  
Footage should be zoomed in until each pixel in the original footage is equal to each pixel in the footage. 

There may be an opportunity to clear something up here. 
Does the zoom level refer to the amount the clip is zoomed to fit to the project, or is it the amount the project window must be zoomed in or out?

If the former, then UHD footage in HD project should show 50%, unless the zoom to original size button is hit, and in the same vein footage of a lesser resolution should show that it is scaled up. 
This is the view that makes more sense, ie: how much is the footage scaled either way?


If the latter, then when I hit zoom to original Size, the zoom indicator should show 200% for UHD footage in HD project.
Comment 1 Wegwerf 2016-06-19 16:50:56 UTC
Evert, I think you are correctly assuming that the "original size" button should set 200% for UHD on FullHD. However, I'm not exactly sure now whether the button shows the zoom-to-fit icon? If yes, then the hint doesn't match the button and function. If not, then button function doesn't match the hint. Oh well...
Comment 2 Evert Vorster 2016-06-19 17:28:08 UTC
We actually need both fit to profile and zoom to original resolution buttons, then all confusion will go away. :)

I remember using that button that is there to zoom in to original resolution when working with footage that is larger than the project.
Comment 3 Jean-Baptiste Mardelle 2016-06-19 18:13:12 UTC
Git commit 8a050baaabc0522701304d34c93b948fccaeb70d by Jean-Baptiste Mardelle.
Committed on 19/06/2016 at 18:13.
Pushed by mardelle into branch 'master'.

Add "Fit to original" and "Adjust and center in frame " in resize options

M  +1    -0    src/effectstack/parametercontainer.cpp
M  +45   -5    src/effectstack/widgets/geometrywidget.cpp
M  +3    -0    src/effectstack/widgets/geometrywidget.h

http://commits.kde.org/kdenlive/8a050baaabc0522701304d34c93b948fccaeb70d
Comment 4 Evert Vorster 2016-06-19 18:17:05 UTC
Thanks, JBM. 

I'm currently using the Applications 16.04 branch in git, will test once I have finished the project I am playing with.
Comment 5 Evert Vorster 2016-06-21 16:55:11 UTC
Works beautifully in git, not back-ported to applicaitons 16.04 branch.